----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65535/#review196925 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java Line 507 (original), 509-514 (patched) <https://reviews.apache.org/r/65535/#comment276908> This was probably left here during development. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Lines 331 (patched) <https://reviews.apache.org/r/65535/#comment276911> Could you add error messages to the asserts so it's easier to understand what is the error if something goes wrong? core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Lines 344-345 (patched) <https://reviews.apache.org/r/65535/#comment276909> What is the purpose of this two lines? core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Lines 373-374 (patched) <https://reviews.apache.org/r/65535/#comment276910> Same as above - Peter Cseh On Feb. 6, 2018, 7:34 p.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65535/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2018, 7:34 p.m.) > > > Review request for oozie, Attila Sasvari and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3173 Coordinator job with frequency using cron syntax creates only one > action in catchup mode > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 91d3508d128032ea5928cd5c6de482a65008c2bc > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 2a648d7c35c1a396e099ab27ab33d91e95d119d5 > > > Diff: https://reviews.apache.org/r/65535/diff/1/ > > > Testing > ------- > > New unit tests: > > * > `TestCoordMaterializeTransitionXCommand#testCronFrequencyCatchupThrottleLessThanDuration()` > * > `TestCoordMaterializeTransitionXCommand#testCronFrequencyCatchupThrottleEqualsDuration` > * > `TestCoordMaterializeTransitionXCommand#testCronFrequencyCatchupThrottleMoreThanDuration` > > > Thanks, > > András Piros > >
