> On Feb. 12, 2018, 8:05 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > > Lines 1680 (patched) > > <https://reviews.apache.org/r/65606/diff/2/?file=1958145#file1958145line1680> > > > > Would give a catchier name and remove comment. > > > > What about more test cases: > > > > * both `resource-manager` and `job-tracker` present at the same level > > * both `resource-manager` and `job-tracker` present at different levels > > * none of these are present
I think it's better to keep both RM and JT as a single variable in the code as they have the same meaning. JT is only there for compatiblity reasons, but it should overwrite RM values of lower levels. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/#review197301 ----------------------------------------------------------- On Feb. 12, 2018, 4:19 p.m., Attila Sasvari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65606/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2018, 4:19 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2687 will add in a whole set of newer schemas that are more > Yarn-centric. Most, if not all, examples currently use pretty old versions of > the schemas. We should take this opportunity to update the examples to the > newest schemas added by OOZIE-2687, which should help demonstrate them. > > It may make sense to keep the older schemas too, to show that older workflows > still work. We have some examples where we have two workflow XML files that > do the same thing in different ways. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > bc0f4050bb3788988d3a5352a15220fbc4fa219d > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > c236dafa5965403c33e1a400509e7c374fe2637c > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1cc569d8d7a0e61905ad6c4e940cefb00da1343d > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 2cdbde4d2fc86a07b35beadc56012c438baf8d54 > examples/src/main/apps/aggregator/coordinator-with-offset.xml > 4c351677f4afc6e85f807106d426bb2f922a28b1 > examples/src/main/apps/aggregator/coordinator.xml > 948edc1adbe09dfb6f7bffb5eebc82f3670658cc > examples/src/main/apps/aggregator/job-with-offset.properties > 9a28ae13e50c40f70db4b0f583a63eb42f97388d > examples/src/main/apps/aggregator/job.properties > aaf4edf7b9d030b5044610698b27a564b008f77b > examples/src/main/apps/aggregator/workflow.xml > 4a801090e31acba23ea49da1c59a8ce4b951c654 > examples/src/main/apps/bundle/job.properties > c06edeb3f42e2eba3367b9486982dabb4caf6436 > examples/src/main/apps/coord-input-logic/job.properties > 2cd137b94999c7e1f68bb54928f1c3ce2838d59d > examples/src/main/apps/coord-input-logic/workflow.xml > 80d31457eff6e78710ad1fb4d4f1b372c0d1e43c > examples/src/main/apps/cron-schedule/coordinator.xml > 48a7de76245e02397b9736a95fa0132504067f9a > examples/src/main/apps/cron-schedule/job.properties > 5b5eb43ca2bf9d8cd1b263ca3b94a552b562a20d > examples/src/main/apps/cron-schedule/workflow.xml > b53922c8f40e691cb637b91cb182172794296a04 > examples/src/main/apps/cron/coordinator.xml > 744d14e870b59d0b89f65a78fea63fffa3ff4b8e > examples/src/main/apps/cron/job.properties > 42875fd5a5ce393cd11717bcc55fc1bb91e0fcd3 > examples/src/main/apps/cron/workflow.xml > 63dff976f9e35a26b0ad09078778748d3d02bc3b > examples/src/main/apps/custom-main/job.properties > b897512a1c6246308ca17b019ce400f3ec06cd7b > examples/src/main/apps/custom-main/workflow.xml > 828dfaa0594aac0539c4e08ae8e37cb89d17eb54 > examples/src/main/apps/datelist-java-main/job.properties > e8356e3a4a2e1ae41e09f5ea124fb5360bd6e8b6 > examples/src/main/apps/datelist-java-main/workflow.xml > b59a12ebd1fc21c9e26f6a5b0348eb9c76375c03 > examples/src/main/apps/demo/job.properties > d70d3208df77e0b612005196907cecd97d7c5d21 > examples/src/main/apps/demo/job.windows.properties > ea948b20009685e1286053549fc1974669819682 > examples/src/main/apps/demo/workflow.xml > 0ceca507adc68c0674b794420c9eb733cb320879 > examples/src/main/apps/distcp/job.properties > ec9422caddcdecfa6ee9a58868cf68d7457ad4db > examples/src/main/apps/distcp/workflow.xml > 6deecb377901613a5bb28fc18bf5beff2d30f252 > examples/src/main/apps/hadoop-el/job.properties > 1d13c27056ac58ad359b5298f12ec046bb4cc61d > examples/src/main/apps/hadoop-el/workflow.xml > d4094d44136a7de2f85f5c9be042d5aab24b90be > examples/src/main/apps/hcatalog/job.properties > e0aa18c264a2fa92b6c3d501d18fa39733d863ff > examples/src/main/apps/hcatalog/job.properties.security > 2fbcc6ee9e5d94d3bba63810e6e788607747940b > examples/src/main/apps/hcatalog/workflow.xml > d6593df1b9104179d79262d663135d73de8b55ec > examples/src/main/apps/hcatalog/workflow.xml.security > aa3522ae4d5b6cb178f80c2e72e45c4c3de9aab5 > examples/src/main/apps/hive/job.properties > dbc7ad2a0b135b8c9f0b6e575086ee8260072756 > examples/src/main/apps/hive/workflow.xml > 449d62d35f2e69d01d9e59f35a0cc9ad057342d2 > examples/src/main/apps/hive/workflow.xml.security > 35321319dcbb0576c5870952e6e805209b8dc240 > examples/src/main/apps/hive2/job.properties > 2640402472d3b2120941834e4653d363fb49914b > examples/src/main/apps/hive2/job.properties.security > ac980cd3cc37e3b3b359c2e3fefe180cf88b56bc > examples/src/main/apps/hive2/workflow.xml > 5f1ccc4fd0791f850c0942452d637048acce13d1 > examples/src/main/apps/hive2/workflow.xml.security > 6f7304def80317429e58cecddc63fe4c1d3edaa6 > examples/src/main/apps/java-main/job.properties > 519c53e7313b6a5b54ab54cb2dd31f123819a0f9 > examples/src/main/apps/java-main/workflow.xml > 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a > examples/src/main/apps/map-reduce/job-with-config-class.properties > 0b14cb749b82fcd165f8db9b1832c650e6970f61 > examples/src/main/apps/map-reduce/job.properties > 7115229b6a2b998f6a5eed503eec554544f67cd7 > examples/src/main/apps/map-reduce/workflow-with-config-class.xml > 0deab665a0175959807491f7ccfec2a47a0cea2a > examples/src/main/apps/map-reduce/workflow.xml > 7fe7fdbe17a941084c01fba91efed274c910f305 > examples/src/main/apps/no-op/job.properties > a839dbb9f01b3786e551e232e8fd75bce0d38391 > examples/src/main/apps/no-op/workflow.xml > a5277d0060a10457347056f225b3508b0e59d7a6 > examples/src/main/apps/pig/job.properties > 53e94eacf1210c54c1999617f74e24bf9dc4a80a > examples/src/main/apps/pig/workflow.xml > 8da2b66882e8b14f8284d7101cdedc67db3d5cb1 > examples/src/main/apps/pyspark/job.properties > 72e09b938a3e36f89d782f26c7e3a654b699f43d > examples/src/main/apps/pyspark/workflow.xml > 4768a6cb5a18099e8e8a613e47c6ec48d79a6c0f > examples/src/main/apps/shell/job.properties > bbc765412b1baad7f9a414814df0d9f896b17acf > examples/src/main/apps/shell/workflow.xml > 46566bd96e65293f7327982dbf92d8d120069577 > examples/src/main/apps/sla/coordinator.xml > 10e9ea3652d565de21014f37e88203645ce7e209 > examples/src/main/apps/sla/job.properties > 698ec6d2384f309c9c19d3df9cb14d4a9e967aae > examples/src/main/apps/sla/workflow.xml > 484091a8292f2532cdd60dd1f0ef2e699f0b6b67 > examples/src/main/apps/spark/job.properties > a509db07c6110014cc83e9ccf5480b6ba7c2371e > examples/src/main/apps/spark/workflow.xml > 1b1a3e889d30ef62200382f49da400ed6d3879fb > examples/src/main/apps/sqoop-freeform/job.properties > 306421abe136f852dcd8e25162d94d7d13bc6a57 > examples/src/main/apps/sqoop-freeform/workflow.xml > 1097da328056d478ea13d8108286d2390d1f8549 > examples/src/main/apps/sqoop/job.properties > afc4de89fa12246c7d5ce8880e857001953b089f > examples/src/main/apps/sqoop/workflow.xml > 0ae05a14f0617b9f2ecd458cc1b69527cf203d87 > examples/src/main/apps/ssh/job.properties > 540db02936a04fa64867fa27d6625abab275b265 > examples/src/main/apps/ssh/workflow.xml > 4b53a8bc0f59e1084feb3d4fab11abdb939344b1 > examples/src/main/apps/streaming/job.properties > 83ea2c35e3195a18390a4852915fc58eb57664d6 > examples/src/main/apps/streaming/job.windows.properties > b216d3eca61f0d8836b2b6227acf3db48ca8c645 > examples/src/main/apps/streaming/workflow.xml > feae1d293a70045f511c79c5489282212640dbf2 > examples/src/main/apps/subwf/job.properties > 3c9af19670a1336135bdefbc6de361e0b8595d08 > examples/src/main/apps/subwf/workflow.xml > 9873a50485d76811f9c981ed8a6bcc30e09089a0 > examples/src/test/resources/localoozieexample-wf.xml > c1eba55aa22446922bff291d1e8f043a74455512 > > > Diff: https://reviews.apache.org/r/65606/diff/2/ > > > Testing > ------- > > > Thanks, > > Attila Sasvari > >
