> On March 26, 2018, 10:40 a.m., Peter Cseh wrote:
> > docs/src/site/twiki/AG_Install.twiki
> > Lines 919-921 (original), 927-937 (patched)
> > <https://reviews.apache.org/r/66250/diff/3/?file=1987000#file1987000line927>
> >
> >     Shouldn't it be enabled by adding the deprecated Service to the 
> > services.ext?

Documentation updated and test case added.


- András


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66250/#review199953
-----------------------------------------------------------


On March 24, 2018, 6:15 p.m., András Piros wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66250/
> -----------------------------------------------------------
> 
> (Updated March 24, 2018, 6:15 p.m.)
> 
> 
> Review request for oozie, Peter Cseh and Robert Kanter.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> [OOZIE-2645] Deprecate Instrumentation in favor of Metrics
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/service/InstrumentationService.java 
> afa35113c7fc258d0da75bdbf183fc6f2a1e54ee 
>   core/src/main/java/org/apache/oozie/util/Instrumentation.java 
> a57b6655da6a6c28eb857691336ab27508ee8092 
>   core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java 
> 1288a3f980435164c38b09edbbbcad51577e694d 
>   core/src/main/resources/oozie-default.xml 
> 966dd29b20ffb4a627418d62403c0cec166dd147 
>   core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 
> b31816e15f5f419e52042187931674fbd3cd4c5b 
>   core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 
> f91d22f668b14bde7437e9a3f854dd87a5565e00 
>   core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 
> 534f5727ce398d6dbf8473bf4442b76e7c2630c4 
>   core/src/test/java/org/apache/oozie/util/TestMetricsInstrumentation.java 
> ab974436769b786d99d10fc3aa951c2a3b16d398 
>   core/src/test/resources/oozie-site-instrumentation.xml 
> ab3f0f5b99aabf149d409c762efd3feb51fe9f6d 
>   docs/src/site/twiki/AG_Install.twiki 
> 8e2d795da838d184940bc177e95e9dfb8b52cc54 
>   docs/src/site/twiki/AG_Monitoring.twiki 
> 523f85133055b80b32b2cf73f1e8c25751cf9fc4 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 
> a94201ded8451cc725b40e9f73182ecaa52be88a 
>   docs/src/site/twiki/WebServicesAPI.twiki 
> c662a5eefdfc012ea6c13256a3df426e1a073965 
> 
> 
> Diff: https://reviews.apache.org/r/66250/diff/3/
> 
> 
> Testing
> -------
> 
> Generated `mkdistro` and saw that `/admin/v2/metrics` is available, and 
> `/admin/instrumentation` isn't.
> 
> 
> Thanks,
> 
> András Piros
> 
>

Reply via email to