----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/#review204336 -----------------------------------------------------------
tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java Line 254 (original), 424 (patched) <https://reviews.apache.org/r/66930/#comment286777> We could check for failedCopyTasks.isEmpty() here, can't we? tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java Lines 429 (patched) <https://reviews.apache.org/r/66930/#comment286776> the "t" in the message might be different here than the original "t" that was null-checked. Please use an error from the failed task list. - Peter Cseh On June 5, 2018, 8:37 a.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66930/ > ----------------------------------------------------------- > > (Updated June 5, 2018, 8:37 a.m.) > > > Review request for oozie, András Piros and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > On a busy Hadoop cluster it can happen that users cannot install properly > Oozie ShareLib. > > > Diffs > ----- > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java dce1c559 > tools/src/test/java/org/apache/oozie/tools/TestBlockSizeCalculator.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestConcurrentCopyFromLocal.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestCopyTaskCallable.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java > ccad273b > > > Diff: https://reviews.apache.org/r/66930/diff/4/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Kinga Marton > >