----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67314/#review204362 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java Lines 95 (patched) <https://reviews.apache.org/r/67314/#comment286832> Is "contains" strong enough here? I can think of two scenarios when it might screw up the parsin: 1) a table name contains a "-" character 2) a query like "select * where price > -3 and price < 0 core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java Lines 98 (patched) <https://reviews.apache.org/r/67314/#comment286833> This changes behavior (for the better I thnik :)) Please update the documentation as well. sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java Lines 50 (patched) <https://reviews.apache.org/r/67314/#comment286830> Please add a test case where this select is quoted - Peter Cseh On May 25, 2018, 7:37 a.m., Denes Bodo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67314/ > ----------------------------------------------------------- > > (Updated May 25, 2018, 7:37 a.m.) > > > Review request for oozie and András Piros. > > > Bugs: OOZIE-3218 > https://issues.apache.org/jira/browse/OOZIE-3218 > > > Repository: oozie-git > > > Description > ------- > > When running a Oozie Sqoop action which has command with --query in place the > query is split into multiple parts causing "Unrecognized argument:" and > in-turn fails. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 69d5e7e > > sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > edfe0c7 > > > Diff: https://reviews.apache.org/r/67314/diff/1/ > > > Testing > ------- > > > Thanks, > > Denes Bodo > >
