[ https://issues.apache.org/jira/browse/OOZIE-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andras Piros updated OOZIE-3233: -------------------------------- Description: With the fix of OOZIE-2726 a small functionality change is included for the following scenario: * between the start and end date there is one DST change * the nominal time of the last action should be maximum 1h before the end time. * this last action will not be created after the OOZIE-2726, because of the DST correction, the nominal time will exceed the end time. The documentation says: {quote} ...the Oozie processing timezone is used to resolve coordinator jobs start/*end times* ... {quote} I think that we should not include functionality changes with test fixtures, so I would remove the DST correction from the end time: [*{{CoordMaterializeTransitionXCommand#materializeActions()}}*|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java#L440]. was: With the fix of OOZIE-2726 a small functionality change is included for the following scenario: * between the start and end date there is one DST start * the nominal time of the last action should be maximum 1h before the end time. * this last action will not be created after the OOZIE-2726, because of the DST correction, the nominal time will exceed the end time. The documentation says that "t_he Oozie processing timezone is used to resolve coordinator jobs start/*end times* ..._". I think that we should not include functionality changes with test fixtures, so I would remove the DST correction from the end time: [https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java#L461] > Remove DST shift from the coordinator job's end time > ---------------------------------------------------- > > Key: OOZIE-3233 > URL: https://issues.apache.org/jira/browse/OOZIE-3233 > Project: Oozie > Issue Type: Bug > Components: coordinator > Affects Versions: 5.0.0 > Reporter: Julia Kinga Marton > Assignee: Julia Kinga Marton > Priority: Major > Attachments: OOZIE-3233-001.patch > > > With the fix of OOZIE-2726 a small functionality change is included for the > following scenario: > * between the start and end date there is one DST change > * the nominal time of the last action should be maximum 1h before the end > time. > * this last action will not be created after the OOZIE-2726, because of the > DST correction, the nominal time will exceed the end time. > The documentation says: > {quote} > ...the Oozie processing timezone is used to resolve coordinator jobs > start/*end times* ... > {quote} > I think that we should not include functionality changes with test fixtures, > so I would remove the DST correction from the end time: > [*{{CoordMaterializeTransitionXCommand#materializeActions()}}*|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java#L440]. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)