[ 
https://issues.apache.org/jira/browse/OOZIE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524955#comment-16524955
 ] 

Andras Piros edited comment on OOZIE-3208 at 6/27/18 11:59 AM:
---------------------------------------------------------------

Thanks for the contribution [~kmarton]!

Can you please make one change more here; in {{ConfigurationService}} please 
use {{try-with-resources}} in order the {{StringWriter#close()}} would be 
called automatically. Thanks!


was (Author: andras.piros):
Thanks for the contribution [~kmarton]! +1

> "It should never happen" error messages should be more specific to root cause
> -----------------------------------------------------------------------------
>
>                 Key: OOZIE-3208
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3208
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>            Reporter: Robert Kanter
>            Assignee: Julia Kinga Marton
>            Priority: Critical
>             Fix For: 5.1.0
>
>         Attachments: OOZIE-3208-001.patch, OOZIE-3208-002.patch
>
>
> If you forget to install the sharelib and you try to run a workflow, the 
> action will fail (as expected), but the error code will be "It should never 
> happen".  That's not a good error code :D
> {noformat}
> 2018-03-29 14:35:02,361  WARN ActionStartXCommand:523 - 
> SERVER[rkanter-MBP.local] USER[rkanter] GROUP[-] TOKEN[] APP[map-reduce-wf] 
> JOB[0000000-180329142919509-oozie-rkan-W] 
> ACTION[0000000-180329142919509-oozie-rkan-W@mr-node] Error starting action 
> [mr-node]. ErrorType [FAILED], ErrorCode [It should never happen], Message 
> [File /user/rkanter/share/lib does not exist]
> org.apache.oozie.action.ActionExecutorException: File /user/rkanter/share/lib 
> does not exist
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addSystemShareLibForAction(JavaActionExecutor.java:646)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addAllShareLibs(JavaActionExecutor.java:760)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.setLibFilesArchives(JavaActionExecutor.java:746)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:984)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1512)
>         at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:243)
>         at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:68)
>         at org.apache.oozie.command.XCommand.call(XCommand.java:290)
>         at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:334)
>         at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:263)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>         at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:181)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at java.lang.Thread.run(Thread.java:745)
> {noformat}
> {noformat}
> Error starting action [mr-node]. ErrorType [FAILED], ErrorCode [It should 
> never happen]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to