[
https://issues.apache.org/jira/browse/OOZIE-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526099#comment-16526099
]
Hadoop QA commented on OOZIE-2955:
----------------------------------
Testing JIRA OOZIE-2955
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
. {color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
error(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [2] new bugs found below threshold in total that
must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:red}-1{color} There are [2] new bugs found below threshold in [client]
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
client/findbugs-new.html
. The most important FindBugs errors are:
. At OozieCLI.java:[lines 717-752]: Switch statement found in
org.apache.oozie.cli.OozieCLI.processCommand(CLIParser, CLIParser$Command)
where default case is missing
. At XOozieClient.java:[line 82]:
java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose
location might be specified by user input
. At OozieCLI.java:[line 2215]: At OozieCLI.java:[line 2207]
. At XOozieClient.java:[line 182]: At XOozieClient.java:[line 166]
. At XOozieClient.java:[line 223]: At XOozieClient.java:[line 201]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 2897
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/644/
> Fix Findbugs warnings related to reliance on default encoding in oozie-client
> -----------------------------------------------------------------------------
>
> Key: OOZIE-2955
> URL: https://issues.apache.org/jira/browse/OOZIE-2955
> Project: Oozie
> Issue Type: Sub-task
> Components: build, client
> Reporter: Jan Hentschel
> Assignee: Julia Kinga Marton
> Priority: Major
> Attachments: OOZIE-2955-002.patch, OOZIE-2955-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the
> reliance on the default encoding in the *oozie-client* module:
> {code}
> [INFO] Found reliance on default encoding in
> org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new
> java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At
> CLIParser.java:[line 169]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At
> OozieCLI.java:[line 845]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new
> java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At
> OozieCLI.java:[line 2171]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.AuthOozieClient.readAuthToken(): new
> java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At
> AuthOozieClient.java:[line 218]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token):
> new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At
> AuthOozieClient.java:[line 248]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new
> java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient]
> At OozieClient.java:[line 412]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$BulkResponseStatus] At
> OozieClient.java:[line 1693]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line
> 1502]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$BundleJobsStatus] At
> OozieClient.java:[line 1667]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$CoordActionInfo] At
> OozieClient.java:[line 1522]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$CoordActionsKill] At
> OozieClient.java:[line 1720]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line
> 1743]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line
> 1455]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$CoordJobsStatus] At
> OozieClient.java:[line 1640]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line
> 1773]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$GetBuildVersion] At
> OozieClient.java:[line 2168]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$GetInstrumentation.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$GetInstrumentation] At
> OozieClient.java:[line 2907]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$GetMetrics.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$GetMetrics] At OozieClient.java:[line
> 2674]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$GetQueueDump.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$GetQueueDump] At OozieClient.java:[line
> 2532]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$GetSystemMode.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$GetSystemMode] At OozieClient.java:[line
> 2126]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$JMSInfo.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$JMSInfo] At OozieClient.java:[line 1005]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$JMSTopic.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$JMSTopic] At OozieClient.java:[line 1218]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$JobIdAction.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$JobIdAction] At OozieClient.java:[line
> 2066]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$JobInfo.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$JobInfo] At OozieClient.java:[line 986]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$JobMetadata.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$JobMetadata] At OozieClient.java:[line
> 1367]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$JobSubmit.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$JobSubmit] At OozieClient.java:[line 717]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$JobsAction.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$JobsAction] At OozieClient.java:[line
> 772]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$JobsStatus.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$JobsStatus] At OozieClient.java:[line
> 1613]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$ListShareLib.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$ListShareLib] At OozieClient.java:[line
> 2269]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$MapClientCallable.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$MapClientCallable] At
> OozieClient.java:[line 610]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$SlaInfo.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$SlaInfo] At OozieClient.java:[line 2043]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$Status.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$Status] At OozieClient.java:[line 2509]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$UpdateCoord.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$UpdateCoord] At OozieClient.java:[line
> 833]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$UpdateSharelib.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$UpdateSharelib] At
> OozieClient.java:[line 2227]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$ValidateXML.call(HttpURLConnection): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$ValidateXML] At OozieClient.java:[line
> 2201]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$WfsForCoordAction.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$WfsForCoordAction] At
> OozieClient.java:[line 1476]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$WorkflowActionInfo.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$WorkflowActionInfo] At
> OozieClient.java:[line 1025]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.OozieClient$WorkflowActionRetriesInfo.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.OozieClient$WorkflowActionRetriesInfo] At
> OozieClient.java:[line 1046]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.XOozieClient.readScript(String): new
> java.io.FileReader(String) [org.apache.oozie.client.XOozieClient] At
> XOozieClient.java:[line 81]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.client.XOozieClient$HttpJobSubmit.call(HttpURLConnection):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.client.XOozieClient$HttpJobSubmit] At
> XOozieClient.java:[line 275]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
