[
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526267#comment-16526267
]
Andras Piros commented on OOZIE-2956:
-------------------------------------
Thanks for the contribution [~kmarton] [~Jan Hentschel]!
[~kmarton] if so, can you please mark these places with
{{@SuppressFBWarnings(value, justification)}} just like
[*here*|https://github.com/apache/oozie/blob/master/client/src/main/java/org/apache/oozie/cli/OozieCLI.java#L1415-L1435]?
Thanks!
> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---------------------------------------------------------------------------
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
> Issue Type: Sub-task
> Components: build, core
> Reporter: Jan Hentschel
> Assignee: Julia Kinga Marton
> Priority: Major
> Attachments: OOZIE-2956-003.patch, OOZIE-2956-1.patch,
> OOZIE-2956-2.patch
>
>
> Currently Findbugs complains about the following warnings related to the
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes()
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.ActionExecutor.registerError(String,
> ActionExecutorException$ErrorType, String):
> java.io.ByteArrayOutputStream.toString()
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.ActionExecutor.registerError(String,
> ActionExecutorException$ErrorType, String): new
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration,
> Path, String): new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line
> 69]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String):
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.action.hadoop.LauncherHelper$1,
> org.apache.oozie.action.hadoop.LauncherHelper$1,
> org.apache.oozie.action.hadoop.LauncherHelper$1,
> org.apache.oozie.action.hadoop.LauncherHelper$1,
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
> WorkflowAction): String.getBytes()
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
> WorkflowAction): String.getBytes()
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process,
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.action.ssh.SshActionExecutor,
> org.apache.oozie.action.ssh.SshActionExecutor] At
> SshActionExecutor.java:[line 684]Another occurrence at
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor,
> org.apache.oozie.action.ssh.SshActionExecutor] At
> SshActionExecutor.java:[line 502]Another occurrence at
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String,
> String): java.io.ByteArrayOutputStream.toString()
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String,
> String): String.getBytes()
> [org.apache.oozie.command.coord.CoordUpdateXCommand,
> org.apache.oozie.command.coord.CoordUpdateXCommand] At
> CoordUpdateXCommand.java:[line 198]Another occurrence at
> CoordUpdateXCommand.java:[line 199]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.service.AuthorizationService.loadAdminUsers(): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.service.AuthorizationService] At
> AuthorizationService.java:[line 172]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.service.WorkflowAppService.readDefinition(String, String,
> Configuration): new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.service.WorkflowAppService] At
> WorkflowAppService.java:[line 132]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.servlet.V1JobServlet.getJob(HttpServletRequest,
> HttpServletResponse): new String(byte[])
> [org.apache.oozie.servlet.V1JobServlet] At V1JobServlet.java:[line 223]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.servlet.V2ValidateServlet.doPost(HttpServletRequest,
> HttpServletResponse): new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.servlet.V2ValidateServlet,
> org.apache.oozie.servlet.V2ValidateServlet] At V2ValidateServlet.java:[line
> 84]Another occurrence at V2ValidateServlet.java:[line 92]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.AuthUrlClient$1.run(): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.util.AuthUrlClient$1] At AuthUrlClient.java:[line 136]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.IOUtils.getResourceAsReader(String, int): new
> java.io.InputStreamReader(InputStream) [org.apache.oozie.util.IOUtils] At
> IOUtils.java:[line 119]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.IOUtils.getResourceAsString(String, int): new
> java.io.InputStreamReader(InputStream) [org.apache.oozie.util.IOUtils] At
> IOUtils.java:[line 136]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.MultiFileReader.openNextReader(): new
> java.io.FileReader(File) [org.apache.oozie.util.MultiFileReader] At
> MultiFileReader.java:[line 86]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.MultiFileReader.openNextReader(): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.util.MultiFileReader] At MultiFileReader.java:[line 82]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.XConfiguration.toXmlString(boolean): new String(byte[])
> [org.apache.oozie.util.XConfiguration] At XConfiguration.java:[line 368]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.XmlUtils.validateXml(Schema, String): String.getBytes()
> [org.apache.oozie.util.XmlUtils] At XmlUtils.java:[line 284]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
