> On July 6, 2018, 1:40 p.m., András Piros wrote: > > tools/src/test/java/org/apache/oozie/tools/OozieSharelibFileOperations.java > > Lines 42-48 (original), 43-51 (patched) > > <https://reviews.apache.org/r/67834/diff/2/?file=2053415#file2053415line43> > > > > Could be extracted to a nested `static class`, and tested separately.
I agree with testing it, but this class was created for the Sharelib testing related file operations, like this method. - Kinga ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67834/#review205796 ----------------------------------------------------------- On July 6, 2018, 8:36 a.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67834/ > ----------------------------------------------------------- > > (Updated July 6, 2018, 8:36 a.m.) > > > Review request for oozie, András Piros, Peter Cseh, and Peter Bacsko. > > > Repository: oozie-git > > > Description > ------- > > Right now sharelib can be created via sharelib create -fs FS_URI -locallib > SHARED_LIBRARY where the SHARED_LIBRARY can be a tarbal or a folder. > It would be nice to have the possibility to define additional folders to be > uploaded into the sharelib, so the users don't have to copy or link the files > together on their machine. > The syntax could be something like -additional-lib > sharelibName=/path/to/source/;/path/to/some/file,sharelibName2=/path/to/some/folder > > > Diffs > ----- > > docs/src/site/twiki/AG_Install.twiki 46363a3b3 > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java 75e932c02 > tools/src/test/java/org/apache/oozie/tools/OozieSharelibFileOperations.java > d344300ed > tools/src/test/java/org/apache/oozie/tools/TestConcurrentCopyFromLocal.java > d77eba69d > tools/src/test/java/org/apache/oozie/tools/TestCopyTaskCallable.java > bce0433c6 > tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java > 5929e5ca0 > > tools/src/test/java/org/apache/oozie/tools/diag/IntegrationTestOozieSharelibCLI.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67834/diff/4/ > > > Testing > ------- > > Tested manually + added integration test > > > Thanks, > > Kinga Marton > >
