[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Piros updated OOZIE-2942:
--------------------------------
Attachment: OOZIE-2942.006.patch
> [examples] Fix Findbugs warnings
> --------------------------------
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
> Reporter: Jan Hentschel
> Assignee: Julia Kinga Marton
> Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch, OOZIE-2942.005.patch,
> OOZIE-2942.006.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
