[ https://issues.apache.org/jira/browse/OOZIE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540439#comment-16540439 ]
Hadoop QA commented on OOZIE-3160: ---------------------------------- Testing JIRA OOZIE-3160 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:green}+1{color} the patch adds/modifies 1 testcase(s) {color:red}-1 RAT{color} . {color:red}-1{color} the patch seems to introduce 2 new RAT warning(s) {color:green}+1 JAVADOC{color} {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) . {color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s) . {color:green}+1{color} the patch does not seem to introduce new Javadoc error(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [1] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:red}-1{color} There are [1] new bugs found below threshold in [core] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The most important FindBugs errors are: . At AsyncXCommandExecutor.java:[lines 133-136]: Should org.apache.oozie.service.AsyncXCommandExecutor$PriorityComparator be a _static_ inner class? . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [client]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} . Tests run: 2909 . Tests failed: 2 . Tests errors: 0 . The patch failed the following testcases: testRequeueOnException(org.apache.oozie.command.coord.TestCoordPushDependencyCheckXCommand) testConcurrencyReachedAndChooseNextEligible(org.apache.oozie.service.TestCallableQueueService) . Tests failing with errors: . {color:orange}Tests failed at first run:{color} TestJMSAccessorService#testConnectionRetryExceptionListener . For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/667/ > PriorityDelayQueue put()/take() can cause significant CPU load due to busy > waiting > ---------------------------------------------------------------------------------- > > Key: OOZIE-3160 > URL: https://issues.apache.org/jira/browse/OOZIE-3160 > Project: Oozie > Issue Type: Bug > Components: core > Environment: all platforms > Reporter: jj > Assignee: Peter Bacsko > Priority: Major > Attachments: 11111111111111.png, 222222222222222222.png, > OOZIE-3160-POC01.patch, OOZIE-3160-POC02.patch, OOZIE-3160-POC02.patch, > PriorityDelayQueue improvement - OOZIE-3160.pdf > > > oozie process always consume high cpu. in my mechine,around 10%. > I check the source code,find take() method in PriorityDelayQueue class。 > code: > {code:java} > public QueueElement<E> take() throws InterruptedException { > QueueElement<E> e = poll(); > while (e == null) { > Thread.sleep(10); > e = poll(); > } > return e; > } > {code} > i think it's the reason of this problem. it's keep while, not await. -- This message was sent by Atlassian JIRA (v7.6.3#76005)