[ 
https://issues.apache.org/jira/browse/OOZIE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559657#comment-16559657
 ] 

Hadoop QA commented on OOZIE-3229:
----------------------------------


Testing JIRA OOZIE-3229

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:red}-1{color} the patch contains 21 line(s) longer than 132 
characters
.    {color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.    {color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
error(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [25] new bugs found below threshold in total 
that must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [25] new bugs found below threshold in [core] 
that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At SLASummaryGetForFilterJPAExecutor.java:[line 619]: 
org.apache.oozie.executor.jpa.sla.SLASummaryGetForFilterJPAExecutor.getActualEndEnd()
 may expose internal representation by returning 
SLASummaryGetForFilterJPAExecutor.actualEndEnd
. At SLASummaryGetForFilterJPAExecutor.java:[line 611]: 
org.apache.oozie.executor.jpa.sla.SLASummaryGetForFilterJPAExecutor.getActualEndStart()
 may expose internal representation by returning 
SLASummaryGetForFilterJPAExecutor.actualEndStart
. At SLASummaryGetForFilterJPAExecutor.java:[line 603]: 
org.apache.oozie.executor.jpa.sla.SLASummaryGetForFilterJPAExecutor.getActualStartEnd()
 may expose internal representation by returning 
SLASummaryGetForFilterJPAExecutor.actualStartEnd
. At SLASummaryGetForFilterJPAExecutor.java:[line 595]: 
org.apache.oozie.executor.jpa.sla.SLASummaryGetForFilterJPAExecutor.getActualStartStart()
 may expose internal representation by returning 
SLASummaryGetForFilterJPAExecutor.actualStartStart
. At SLASummaryGetForFilterJPAExecutor.java:[line 555]: 
org.apache.oozie.executor.jpa.sla.SLASummaryGetForFilterJPAExecutor.getCreatedEnd()
 may expose internal representation by returning 
SLASummaryGetForFilterJPAExecutor.createdEnd
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 2908
.    Tests failed: 1
.    Tests errors: 0

.    The patch failed the following testcases:

testBundleSLA(org.apache.oozie.servlet.TestV2SLAServlet)

.    Tests failing with errors:


{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/693/



> Improved filtering options in V2SLAServlet
> ------------------------------------------
>
>                 Key: OOZIE-3229
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3229
>             Project: Oozie
>          Issue Type: New Feature
>          Components: client
>    Affects Versions: 5.0.0, 4.3.1
>            Reporter: Andras Piros
>            Assignee: Andras Salamon
>            Priority: Major
>             Fix For: 5.1.0
>
>         Attachments: OOZIE-3229-1.patch
>
>
> Currently we can apply a range of filters on top of {{V2SLAServlet}} that can 
> be used in a rich but undocumented set of ways:
> * {{id}}
> * {{parent_id}}
> * {{event_status}}
> * {{app_name}}
> * {{nominal_start}}
> * {{nominal_end}}
> Need to refactor {{V2SLAServlet}} to feature:
> * a richer set of {{SLAEvent}}, {{SLARegistration}}, and {{SLASummary}} 
> filtering based on their attributes
> * filter options will always be {{AND}}-ed, never {{OR}}-ed to each other
> * maintain compatibility with the parameter names and behavior used thus far
> * remove {{SLASummaryFilter}} and refactor 
> {{SLASummaryGetForFilterJPAExecutor}} as just another possibility for 
> confusion
> * document new functionality with rich use case / example library so that 
> users can leverage



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to