[ https://issues.apache.org/jira/browse/OOZIE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571435#comment-16571435 ]
Hadoop QA commented on OOZIE-3320: ---------------------------------- Testing JIRA OOZIE-3320 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) . {color:green}+1{color} the patch does not seem to introduce new Javadoc error(s) . {color:red}ERROR{color}: the current HEAD has 2 Javadoc error(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} . Tests run: 2914 . {color:orange}Tests failed at first run:{color} TestCoordChangeXCommand#testCoordChangeEndTime3 . For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/732/ > Oozie ShellAction should support absolute bash file path > -------------------------------------------------------- > > Key: OOZIE-3320 > URL: https://issues.apache.org/jira/browse/OOZIE-3320 > Project: Oozie > Issue Type: Improvement > Components: action > Affects Versions: 5.0.0, 4.3.1 > Reporter: Roey Shem Tov > Assignee: Roey Shem Tov > Priority: Major > Labels: patch > Attachments: OOZIE-3086.patch > > > bash files that saved on shared mount, cannot be execute by the ShellAction > in proper way. > Example: > Worker-1,Worker-2,Worker-3 have shared mount /mnt/hadoop > on /mnt/hadoop there is a file script.sh > Right now there is two options to submit it using ShellAction: > # Upload it to hdfs, add it as a file and submit script.sh > # use bash as exec and file location (/mnt/hadoop/script.sh) as argument > (e.g <exec>bash>/exec><argument>/mnt/hadoop/script.sh</argument> > Best option is that the <exec> command will support shared mounted file : > <exec>/mnt/hadoop/script.sh</exec> > > This code is taking only the file name instead it full path: > {code:java} > String exec = actionXml.getChild("exec", ns).getTextTrim(); > String execName = new Path(exec).getName(); > actionConf.set(ShellMain.CONF_OOZIE_SHELL_EXEC, execName); > {code} > > Best option to support shared mount file is to support file:// starting for > bash files that are local (or shared by mount), e.g: > {code:java} > String exec = actionXml.getChild("exec", ns).getTextTrim(); String execName; > String localFilePrefix = "file://"; > // When exec starts with 'file://' refer it as local file. > if (exec.startsWith(localFilePrefix)) > execName = exec.substring(localFilePrefix.length()); > else execName = new Path(exec).getName(); > actionConf.set(ShellMain.CONF_OOZIE_SHELL_EXEC, execName); > {code} > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)