> On Aug. 7, 2018, 1:01 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/command/XCommand.java > > Lines 84 (patched) > > <https://reviews.apache.org/r/68255/diff/1/?file=2069835#file2069835line84> > > > > Typo: eventService
Fixed it, later removed the annotation. > On Aug. 7, 2018, 1:01 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/command/XCommand.java > > Line 82 (original), 85 (patched) > > <https://reviews.apache.org/r/68255/diff/1/?file=2069835#file2069835line85> > > > > Actually `eventService` is only written from inside one of the > > constructors, so it could - and should - be `static final`. Maybe can also > > be `private` and provide a getter for the ones wanting to reach it, or at > > least a `@VisibleForTesting`, when that's the case. Writing the static variable from the constuctor is not the best idea, findbugs also gives us ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD warning. I've replaced the variable with a protected static getEventService method. > On Aug. 7, 2018, 1:01 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/util/Instrumentation.java > > Lines 710-711 (patched) > > <https://reviews.apache.org/r/68255/diff/1/?file=2069836#file2069836line710> > > > > Any other way to refactor? Refactored. Annotation eliminated. - Andras ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68255/#review206941 ----------------------------------------------------------- On Aug. 7, 2018, 12:54 p.m., Andras Salamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68255/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2018, 12:54 p.m.) > > > Review request for oozie, András Piros and Kinga Marton. > > > Repository: oozie-git > > > Description > ------- > > 3 excptions replaced by annotations, the 4th one affects generated code, > still using a (simpified) XML for that. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/XCommand.java 7b8f47cc > core/src/main/java/org/apache/oozie/util/Instrumentation.java 8bcb64c1 > findbugs-filter.xml 133178f0 > fluent-job/fluent-job-api/pom.xml 4c9b8533 > > fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/GraphVisualization.java > 437d6b3b > fluent-job/pom.xml 5b24c911 > pom.xml 92358aa2 > > > Diff: https://reviews.apache.org/r/68255/diff/1/ > > > Testing > ------- > > > Thanks, > > Andras Salamon > >
