[ https://issues.apache.org/jira/browse/OOZIE-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639759#comment-16639759 ]
Julia Kinga Marton commented on OOZIE-3277: ------------------------------------------- [~andras.piros], the long line is the following one: {code:java} longLines=$(grep "^+" "${PATCHFILE}" | grep -v "^+++" | awk 'BEGIN{count=0}{if ( length > 133 ) { count=count+1} }END{ print count}'){code} This line is an old one, I have addressed a shell check issue, this is why is reported. However, I prefer to have it a little longer than splitted, because I consider it more readable this way. > [build] Check for star imports in patches in pre-commit > ------------------------------------------------------- > > Key: OOZIE-3277 > URL: https://issues.apache.org/jira/browse/OOZIE-3277 > Project: Oozie > Issue Type: Improvement > Components: build > Reporter: Peter Cseh > Assignee: Julia Kinga Marton > Priority: Minor > Labels: newbie > Attachments: OOZIE-3277-001.patch, OOZIE-3277-002.patch > > > We don't like to have star imports like {{import java.util.*;}} in our > codebase yet there is no automatic check for it in the pre-commit hook. > We should add one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)