-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69330/
-----------------------------------------------------------

(Updated 十一月 28, 2018, 12:14 p.m.)


Review request for oozie, András Piros and Peter Bacsko.


Repository: oozie-git


Description
-------

Auth token cache file name should include Oozie URL, link to oozie-3379.


Diffs (updated)
-----

  
core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 
1cbd4749 


Diff: https://reviews.apache.org/r/69330/diff/2/

Changes: https://reviews.apache.org/r/69330/diff/1-2/


Testing
-------

I added a test for authOozieClients with the different oozieUrl.
I changed the code for EmbeddedServletContainer. Because this patch needs to 
bind the cache file to oozieUrl, you need to test whether multiple different 
clients can use the cache. In the original EmbeddedServletContainer code, the 
port was random and could not get a given container context path. So the port 
binding needs to be added.


File Attachments
----------------

oozie-3379-6.patch
  
https://reviews.apache.org/media/uploaded/files/2018/11/27/ec465408-bcbc-44bc-a816-7ff73e3c0e68__oozie-3379-6.patch


Thanks,

zhang junfan

Reply via email to