----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69469/#review210927 -----------------------------------------------------------
Overall direction is OK. Please add some unit tests, and sample `oozie-instrumentation.log` snippets. core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java Lines 71 (patched) <https://reviews.apache.org/r/69469/#comment295765> `currentMaterializedJobsCount` would be a better name. core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java Lines 72 (patched) <https://reviews.apache.org/r/69469/#comment295766> `currentMaterializedDelayedJobsCount` would be a better name. core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java Lines 174 (patched) <https://reviews.apache.org/r/69469/#comment295763> Typo in variable name. What about instead: `final long now = ...` - András Piros On Nov. 28, 2018, 11:56 a.m., zhang junfan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69469/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2018, 11:56 a.m.) > > > Review request for oozie and András Piros. > > > Repository: oozie-git > > > Description > ------- > > We have multiple Oozie scheduled clusters. The problem that is currently > encountered is that some materialize queues are too late to process during > the peak hours of the scheduled tasks. We need to get the metrics of the > delay queue for alarm monitoring and adjust the configuration to optimize. > Currently we have added metrics for queue size and latency in Oozie > CoordMaterializeTriggerService class, in order to reflect the general trend > of current scheduling. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > 1cbd4749 > > > Diff: https://reviews.apache.org/r/69469/diff/1/ > > > Testing > ------- > > > Thanks, > > zhang junfan > >
