[ https://issues.apache.org/jira/browse/OOZIE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703081#comment-16703081 ]
Hadoop QA commented on OOZIE-3390: ---------------------------------- Testing JIRA OOZIE-3390 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any star imports . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:green}+1{color} the patch adds/modifies 1 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} Javadoc generation succeeded with the patch . {color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) . {color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [1] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:red}-1{color} There are [1] new bugs found below threshold in [sharelib/oozie] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html . The most important FindBugs errors are: . At ShellContentWriter.java:[line 101]: This usage of java/lang/Runtime.exec(Ljava/lang/String;)Ljava/lang/Process; can be vulnerable to Command Injection . At ShellContentWriter.java:[line 70]: At ShellContentWriter.java:[line 67] . At ShellContentWriter.java:[line 101]: At ShellContentWriter.java:[line 97] . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/git]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:green}+1{color} There are no new bugs found in [tools]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} . Tests run: 3077 {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/932/ > shell action's stderr contains a bogus error message (since 5.0.0) > ------------------------------------------------------------------- > > Key: OOZIE-3390 > URL: https://issues.apache.org/jira/browse/OOZIE-3390 > Project: Oozie > Issue Type: Bug > Affects Versions: 5.1.0 > Reporter: Attila Sasvari > Assignee: Julia Kinga Marton > Priority: Blocker > Fix For: 5.1.0 > > Attachments: OOZIE-3390-001.patch, OOZIE-3390-002.patch > > > Shell action's stderr contains an error message about path. > I executed shell action example to test Oozie 5.1 rc1, the job finished with > success, but stderr of the job contained "Path echo doesn't appear to exist". > https://github.com/apache/oozie/blob/27e4bf1688a6a7750b9c8454de5021337696fd61/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellContentWriter.java#L91 > {code} > writeLine(errorStream, "Path " + filename + " doesn't appear > to exist"); > {code} > The problem is that we ignore the PATH of the process. -- This message was sent by Atlassian JIRA (v7.6.3#76005)