----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69492/#review210973 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java Line 121 (original), 121 (patched) <https://reviews.apache.org/r/69492/#comment295794> !isEmpty() might be nicer core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Line 121 (original), 120 (patched) <https://reviews.apache.org/r/69492/#comment295803> Could you please add assert message. core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 127 (patched) <https://reviews.apache.org/r/69492/#comment295795> Could you please assertMessage core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 179-184 (original), 183-188 (patched) <https://reviews.apache.org/r/69492/#comment295796> This code (PUT) appears multiple times. Could you extract it to a method? core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Line 184 (original), 188 (patched) <https://reviews.apache.org/r/69492/#comment295804> Could you please add assert message. core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 218-223 (original), 222-227 (patched) <https://reviews.apache.org/r/69492/#comment295797> This code (PUT) appears multiple times. Could you extract it to a method? core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Line 223 (original), 227 (patched) <https://reviews.apache.org/r/69492/#comment295805> Could you please add assert message. core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 313-316 (original), 317-320 (patched) <https://reviews.apache.org/r/69492/#comment295798> This code (GET) appears multiple times. Could you extract it to a method? core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 334-337 (original), 338-341 (patched) <https://reviews.apache.org/r/69492/#comment295799> This code (GET) appears multiple times. Could you extract it to a method? core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 355-358 (original), 359-362 (patched) <https://reviews.apache.org/r/69492/#comment295800> This code (GET) appears multiple times. Could you extract it to a method? core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 419-422 (original), 423-426 (patched) <https://reviews.apache.org/r/69492/#comment295801> This code (GET) appears multiple times. Could you extract it to a method? core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 440-443 (original), 444-447 (patched) <https://reviews.apache.org/r/69492/#comment295802> This code (GET) appears multiple times. Could you extract it to a method? - Andras Salamon On Nov. 30, 2018, 12:49 p.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69492/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2018, 12:49 p.m.) > > > Review request for oozie, Andras Salamon and Kinga Marton. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3389 Getting input dependency list on the UI throws NPE > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java > d37cfe5125a5c3a665b3e33e6ac3fd5581fe278f > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java > 56aef1c1779ed7446852af42f25c5ca058e473e4 > > core/src/test/java/org/apache/oozie/coord/input/dependency/TestCoordOldInputDependency.java > PRE-CREATION > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java > bacfe89bb3d836da1f6e559fa68a5bf4db970b09 > > > Diff: https://reviews.apache.org/r/69492/diff/1/ > > > Testing > ------- > > Introduced new unit test class `TestCoordOldInputDependency`. > > > Thanks, > > András Piros > >
