> On Nov. 26, 2018, 12:57 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/util/TestBufferDrainer.java > > Lines 49 (patched) > > <https://reviews.apache.org/r/69408/diff/3/?file=2110238#file2110238line49> > > > > `EXIT_VALUE_ON_ERROR`
The exit value is always 1 not only on error but on the successful finish as well. > On Nov. 26, 2018, 12:57 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/util/TestBufferDrainer.java > > Lines 50-51 (patched) > > <https://reviews.apache.org/r/69408/diff/3/?file=2110238#file2110238line50> > > > > `@Rule public ExpectedException expectedException = > > ExpectedException.none();` would be way more readable. This is not really an expected exception. Junit only catches the exception in the main thread. My solution is based on this suggestion: https://stackoverflow.com/a/2596530/21348 - Andras ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69408/#review210855 ----------------------------------------------------------- On Nov. 23, 2018, 2:28 p.m., Andras Salamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69408/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2018, 2:28 p.m.) > > > Review request for oozie, András Piros and Kinga Marton. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3382 - Optimize SshActionExecutor's drainBuffers method > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > 3e0e3c573 > core/src/main/java/org/apache/oozie/util/BufferDrainer.java PRE-CREATION > core/src/test/java/org/apache/oozie/util/TestBufferDrainer.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69408/diff/3/ > > > Testing > ------- > > Unit tests executed 50 times using grind. > > > Thanks, > > Andras Salamon > >
