[
https://issues.apache.org/jira/browse/OOZIE-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731919#comment-16731919
]
Andras Piros commented on OOZIE-3400:
-------------------------------------
Thanks for the contribution [~asalamon74]! +1
> Fix PurgeService sub-sub-workflow checking
> ------------------------------------------
>
> Key: OOZIE-3400
> URL: https://issues.apache.org/jira/browse/OOZIE-3400
> Project: Oozie
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Andras Salamon
> Assignee: Andras Salamon
> Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3400-00.patch, OOZIE-3400-01.patch,
> OOZIE-3400-02.patch, OOZIE-3400-03.patch
>
>
> Purge service
> [checks|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java#L222-L223]
> sub-workflows before it deletes a workflow. If some of the sub-workflows is
> not yet ready to be purged it does not delete the workflow. Several unit
> tests also checks this, e. g.
> [testPurgeWFWithSubWF1|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java#L2271].
> This check is recursive, it also checks sub-sub-workflows,
> sub-sub-sub-workflows....
> The recursive check is buggy. Let's assume that we have a workflow (A) with a
> single sub-workflow (B), which also has a sub-sub-workflow (C). If A is ready
> to be purged, B is ready to be purged, and C is not ready to be purged then
> the current implementation correctly recognizes that C and B is not
> purgeable, but it purges A. Instead of this, it should also recognize that
> it's not possible to purge A.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
