[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733477#comment-16733477 ]
Andras Piros commented on OOZIE-3407: ------------------------------------- Thanks [~asalamon74] for the contribution! Skimmed through the patch on RB. > Cleanup TestPurgeXCommand > ------------------------- > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task > Affects Versions: trunk > Reporter: Andras Salamon > Assignee: Andras Salamon > Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)