[ 
https://issues.apache.org/jira/browse/OOZIE-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737106#comment-16737106
 ] 

Peter Cseh commented on OOZIE-2949:
-----------------------------------

Thanks for the patch [~asalamon74]!
I have a few review comments:
# please use org.junit instead of junit.framework when importing assertEquals
# don't forget to update the [Sqoop action 
documentation|https://github.com/apache/oozie/blob/master/docs/src/site/markdown/DG_SqoopActionExtension.md]
 with the new behavior

I'm a bit worried about changing default behavior, but I can't think of a 
scenario when this would break things. Can you?

> Escape quotes whitespaces in Sqoop <command> field
> --------------------------------------------------
>
>                 Key: OOZIE-2949
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2949
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: 4.3.0
>            Reporter: Peter Cseh
>            Assignee: Andras Salamon
>            Priority: Major
>             Fix For: 5.2.0
>
>         Attachments: OOZIE-2949-0.patch, OOZIE-2949-01.patch, 
> OOZIE-2949-02.patch
>
>
> The current behavior of the Sqoop action is:
> {noformat}
> The Sqoop command can be specified either using the command element or 
> multiple arg elements.
> When using the command element, Oozie will split the command on every space 
> into multiple arguments.
> When using the arg elements, Oozie will pass each argument value as an 
> argument to Sqoop.
> {noformat}
> This prevents the user to simply copy-paste the command worked in the shell 
> into the workflow.xml.
> We should split the <command> field by taking quotes into account, similar to 
> what OOZIE-2391
> did for the Spark action's <spark-opts> field.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to