----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69771/ -----------------------------------------------------------
Review request for oozie and Andras Salamon. Repository: oozie-git Description ------- When I read FsActionExecutor.java, I found a not good code in this class. When judging which logic to use based on commands, should use "switch/case" replace "if/else": “if/else” make the code hard to read “if/else” make the code hard to extend “if/else” has low efficience So I suggest using “switch/case” instead. Diffs ----- core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java de55793c Diff: https://reviews.apache.org/r/69771/diff/1/ Testing ------- Thanks, Kinga Marton
