[ 
https://issues.apache.org/jira/browse/OOZIE-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757287#comment-16757287
 ] 

Andras Salamon commented on OOZIE-3408:
---------------------------------------

I've started to build a db with lots of records to be able to create a new unit 
test, but I realised that it's too slow using simple record insertions and it's 
not too clean using db imports. I think unit tests are not the best approach 
for testing PurgeXCommand on a large database.

> Create new unit test class for PurgeXCommand
> --------------------------------------------
>
>                 Key: OOZIE-3408
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3408
>             Project: Oozie
>          Issue Type: Sub-task
>          Components: tests
>            Reporter: Andras Salamon
>            Assignee: Andras Salamon
>            Priority: Major
>
> There is one unit test class for {{PurgeXCommand}}, {{TestPurgeXCommand}} 
> which needs to be cleaned up. This class tests the selection of the purgeable 
> records. Most of the test cases are rather small, only a few workflows, 
> coordinators, bundles have to be checked.
> It is also very important that purge service works correctly if large number 
> of records has to be checked. Purge service should not only select the 
> purgeable records correctly, it has to do that in a fast and memory efficient 
> ways.
> Since {{TestPurgeXCommand}} is already very large, a new class should be 
> introduced to contain these tests. Probably the two classes will have a 
> common superclass.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to