> On Feb. 26, 2019, 12:08 p.m., Andras Salamon wrote: > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > > Lines 461 (patched) > > <https://reviews.apache.org/r/70042/diff/2/?file=2126600#file2126600line461> > > > > If neither positive nor negative is present, then the assertTrue above > > should give us an error. > > > > If I understand correctly we reach this fail if the collection has no > > --files / --archives item.
Just in case if --files or --archives changes the test will let us know. I tried to provide meaningful error message, I hope I managed to. - Denes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70042/#review213221 ----------------------------------------------------------- On Feb. 26, 2019, 4:41 p.m., Denes Bodo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70042/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2019, 4:41 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3440 > https://issues.apache.org/jira/browse/OOZIE-3440 > > > Repository: oozie-git > > > Description > ------- > > Failing Oozie Launcher, Main class > [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File > file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > 28d9c5cc4 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 7ccd26ad5 > > > Diff: https://reviews.apache.org/r/70042/diff/3/ > > > Testing > ------- > > Unit tests run > > > Thanks, > > Denes Bodo > >
