-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70072/#review213332
-----------------------------------------------------------


Ship it!




Ship It!

- Kinga Marton


On March 1, 2019, 1:55 p.m., Denes Bodo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70072/
> -----------------------------------------------------------
> 
> (Updated March 1, 2019, 1:55 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1702
>     https://issues.apache.org/jira/browse/OOZIE-1702
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> A lot of warnings are thrown during Oozie compilation, complaining about 
> javadoc mistakes, missing links etc among probably other severe ones. This 
> clutters the output. This JIRA is to fix these warnings
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/ActionExecutor.java 1770b973a 
>   
> core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
>  095cdd27c 
>   core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java 
> a64d128e3 
>   core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 
> 634d3b853 
>   core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java 
> 031be25b9 
>   core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java 
> 274db7830 
>   core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java 
> 0480f06e3 
>   core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java 
> f07f43199 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 231b38ea8 
>   core/src/main/java/org/apache/oozie/action/hadoop/LauncherHelper.java 
> a71d93091 
>   
> core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
>  a4dd13bb3 
>   core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 
> d8b1f0393 
>   core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 
> 8465acddb 
>   core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java 
> 9591cd954 
>   core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java 
> 5f399c4d1 
>   core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 
> ffe27e3ff 
>   core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java 
> 1e37e8009 
>   core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java 
> d3d389ee5 
>   core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java 
> 61244ccaa 
>   core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java 
> 6b3a2e5cb 
>   core/src/main/java/org/apache/oozie/command/TransitionXCommand.java 
> 0c101032e 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 7b2dbd560 
>   core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java 
> e6a9c5438 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  b3174d2d1 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java
>  83c7e2f41 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> 4e4a569fe 
>   core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 
> 6cf7c05c6 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  ec9ef4181 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> f46f2545d 
>   core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 
> cae9591dd 
>   core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java 
> 0b4045afc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> ea61e222a 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 
> 22075464a 
>   core/src/main/java/org/apache/oozie/command/wf/BulkWorkflowXCommand.java 
> 74dfd52be 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 58f203f27 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 
> 1509c387c 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 
> ef9799002 
>   core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 
> 9ed4336f6 
>   core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 3467eef34 
>   core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java c3fecd87e 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java e0c6af962 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java 12c0b81ad 
>   
> core/src/main/java/org/apache/oozie/coord/input/logic/CoordInputLogicEvaluatorUtil.java
>  2306edeb9 
>   core/src/main/java/org/apache/oozie/dependency/DependencyChecker.java 
> 5e9ae7468 
>   core/src/main/java/org/apache/oozie/dependency/URIHandler.java b465b9a18 
>   core/src/main/java/org/apache/oozie/event/EventQueue.java 67fb0f935 
>   core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java 
> e98d10a6f 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BinaryBlobValueHandler.java 
> 92b37f876 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java
>  afd7903ef 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  25b8f36e9 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsDeleteJPAExecutor.java
>  97584e80b 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java
>  0a8eb9a31 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java
>  6f30a424c 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/StringBlobValueHandler.java 
> c2e246a6e 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionDeleteJPAExecutor.java
>  810f0e663 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  ed2400b11 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java
>  9ae364639 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  3ceda38c0 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java
>  01fe53495 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java
>  9e68f49c6 
>   core/src/main/java/org/apache/oozie/jms/ConnectionContext.java 4a76dfbe2 
>   core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java 75751eba4 
>   core/src/main/java/org/apache/oozie/local/LocalOozie.java 6475f33ed 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> 6f72c4193 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 
> a94260002 
>   core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 
> 05cdc555a 
>   core/src/main/java/org/apache/oozie/service/JMSTopicService.java a28330b6b 
>   core/src/main/java/org/apache/oozie/service/JPAService.java cefcb43b8 
>   
> core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java
>  b57a2a5c6 
>   core/src/main/java/org/apache/oozie/service/ProxyUserService.java 4bfd52779 
>   core/src/main/java/org/apache/oozie/service/SLAStoreService.java 02899ccee 
>   core/src/main/java/org/apache/oozie/service/SchedulerService.java 81fbc0d19 
>   core/src/main/java/org/apache/oozie/service/SchemaService.java 14d1eeb14 
>   core/src/main/java/org/apache/oozie/service/Services.java 739160542 
>   core/src/main/java/org/apache/oozie/service/StoreService.java 7868e021a 
>   core/src/main/java/org/apache/oozie/service/URIHandlerService.java 
> c4a370179 
>   core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 
> 17d1d2e1e 
>   core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java 
> 72e0fe480 
>   core/src/main/java/org/apache/oozie/service/XLogService.java 1ac82f5a8 
>   core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 85610eb51 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 31456503a 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java f351ae7a6 
>   core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java 0ff9c6aa5 
>   core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java 8eb6ee1a0 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9acd5719a 
>   core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java a582b1b12 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java c2b90c179 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 3d7d6e8a5 
>   core/src/main/java/org/apache/oozie/sla/SLACalculator.java db7186511 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java 390500341 
>   core/src/main/java/org/apache/oozie/sla/listener/SLAEventListener.java 
> ab771043f 
>   core/src/main/java/org/apache/oozie/store/OozieSchema.java ea785d397 
>   core/src/main/java/org/apache/oozie/store/SLAStore.java 34f47fb83 
>   core/src/main/java/org/apache/oozie/store/Store.java b60f0225d 
>   core/src/main/java/org/apache/oozie/store/WorkflowStore.java 573bcdd2e 
>   core/src/main/java/org/apache/oozie/util/BufferDrainer.java 304fd6d5d 
>   core/src/main/java/org/apache/oozie/util/ConfigUtils.java af54145c9 
>   core/src/main/java/org/apache/oozie/util/StringUtils.java af7ccd6bb 
>   core/src/main/java/org/apache/oozie/util/XConfiguration.java d6e59a63d 
>   core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java 
> af55b068a 
>   core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java 37615bc32 
>   core/src/main/java/org/apache/oozie/util/db/SqlStatement.java 1229ad20b 
>   core/src/main/java/org/apache/oozie/workflow/WorkflowInstance.java 
> 931364280 
>   core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java 
> 22c14fce7 
>   
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 
> a767124b2 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/JavaMain.java 
> 34d1a3e78 
>   
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandler.java
>  c47144dca 
>   
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java
>  bb12bfa93 
>   
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsHandler.java
>  93731adef 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java 
> 554652e4c 
> 
> 
> Diff: https://reviews.apache.org/r/70072/diff/4/
> 
> 
> Testing
> -------
> 
> mvn javadoc:javadoc does not show warning
> 
> 
> Thanks,
> 
> Denes Bodo
> 
>

Reply via email to