[ 
https://issues.apache.org/jira/browse/OOZIE-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811466#comment-16811466
 ] 

Andras Salamon commented on OOZIE-3463:
---------------------------------------

Thanks [~nobigo] for the very quick patch. I'll check it in more details, can 
you please address the "the patch contains 5 line(s) longer than 132 
characters" warning in the meantime?

> Migrate from com.google.common.base.Charsets to 
> java.nio.charset.StandardCharsets
> ---------------------------------------------------------------------------------
>
>                 Key: OOZIE-3463
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3463
>             Project: Oozie
>          Issue Type: Improvement
>            Reporter: Andras Salamon
>            Assignee: duan xiong
>            Priority: Major
>         Attachments: OOZIE-3463-001.patch
>
>
> Oozie usesĀ {{com.google.common.base.Charsets}} in several places. Since Java 
> 1.7 it's much easier to use the builtin {{java.nio.charset.StandardCharsets}} 
> class as suggested [here|https://stackoverflow.com/a/16066990/21348].
> We should also {{name()}} instead of {{toString()}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to