[ https://issues.apache.org/jira/browse/OOZIE-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845960#comment-16845960 ]
Andras Salamon commented on OOZIE-3335: --------------------------------------- This patch replaced lots of {{Map<String, List<String>>}} with {{ListMultimap<String, String>}}. Although I find this collection quite useful, recently we started to remove lots of Guava code from the codebase, so it's maybe not the best idea to add quite a few more guava code.Maybe we could use [commons-collections MultiMap|https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/MultiMap.html] instead. > Cleanup parseFilter methods > --------------------------- > > Key: OOZIE-3335 > URL: https://issues.apache.org/jira/browse/OOZIE-3335 > Project: Oozie > Issue Type: Improvement > Components: core > Affects Versions: trunk > Reporter: Andras Salamon > Assignee: Andras Salamon > Priority: Minor > Attachments: OOZIE-3335-01-wip.patch, OOZIE-3335-02-wip.patch, > OOZIE-3335-03-wip.patch > > > The {{parseFilter}} method is implemented several times in oozie: > {noformat} > servlet/SLAServlet.java > util/JobsFilterUtils.java > DagEngine.java > CoordinatorEngine.java (parseJobFilter and parseJobsFilter methods) > BundleEngine.java (parseBulkFilter method){noformat} > The implementations are quite similar. Code duplication should be eliminated. > OOZIE-3229 will introduce a new utility class for filter parsing, all the > other classes should use it as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)