[ 
https://issues.apache.org/jira/browse/OOZIE-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849865#comment-16849865
 ] 

Andras Salamon commented on OOZIE-3359:
---------------------------------------

I've checked the code and found only the following places:
 * {{ShellMain}}: OOZIE-3392 will address this
 * {{TestCoordCommandUtil}}: do we need to fix test classes as well? Maybe we 
can just use the JDK 1.8 version with a reasonably large timeout.
 * {{TestSShActionExecutor}}: do we need to fix test classes as well? Maybe we 
can just use the JDK 1.8 version with a reasonably large timeout.

{{ShellContentWrites}} uses the new JDK 1.8 version of {{waitFor}} with a 
timeout parameter, so it's not a problem.

> Check for Process#waitFor() usage and fix it in order to avoid indefinite 
> waiting
> ---------------------------------------------------------------------------------
>
>                 Key: OOZIE-3359
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3359
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Julia Kinga Marton
>            Assignee: Julia Kinga Marton
>            Priority: Major
>             Fix For: 5.2.0
>
>
> {{Process#waitFor()}} will block until the process finishes. There are 
> situations where this will wait indefinitely. A similar case was in 
> SshActionExecutor, fixed in OOZIE-3354.
> Let's check the code for other usages, and fix it.
> Maybe we should check if we can use somehow the Process#waitFor(long timeout, 
> TimeUnit timeUnit) instead of it. The tricky part is that this method is 
> available only in Java 8. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to