[ 
https://issues.apache.org/jira/browse/OOZIE-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856574#comment-16856574
 ] 

Andras Salamon commented on OOZIE-3480:
---------------------------------------

Thanks [~zuston] this will be really useful metric.
 * Oozie already stores {{jobstatus}} and {{windowjobstatus}} info for each 
action like this:
{noformat}
    "jobstatus.FAILED" : {
      "value" : 10
    },
    "jobstatus.KILLED" : {
      "value" : 279
    },
    "jobstatus.PREP" : {
      "value" : 0
    },
    "jobstatus.RUNNING" : {
      "value" : 4
    },
...
    "windowjobstatus.FAILED" : {
      "value" : 0
    },
    "windowjobstatus.KILLED" : {
      "value" : 0
    },
    "windowjobstatus.PREP" : {
      "value" : 0
    },
{noformat}

            I think we should use a more similar format for the 
{{windowactionstatus}} instead of the format like {{ssh#ERROR}}
 * You introduced a new metric called {{windowactionstatus}} similar to 
{{windowjobstatus}}. What about also introducing a metric like {{actionstatus}} 
similar to {{jobstatus}}?
 * Could you please also add some unit tests (just like you added in OOZIE-3393)

Please also upload the next patch to ReviewBoard.

> Add windowactionstatus metrics in DBLiteWorkflowStoreService
> ------------------------------------------------------------
>
>                 Key: OOZIE-3480
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3480
>             Project: Oozie
>          Issue Type: Improvement
>          Components: core
>            Reporter: Junfan Zhang
>            Assignee: Junfan Zhang
>            Priority: Major
>         Attachments: oozie-3480-1.patch, oozie-instrumentation.log
>
>
> The {{windowjobstatus}} metric is useful when you need to monitor task 
> execution. However, when there are more action types of online tasks, it is 
> necessary to monitor the execution of each action. At this time, the 
> {{windowactionstatus}} metrics is necessary. The associated snippet of 
> instrumentation.log is in attachments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to