[ https://issues.apache.org/jira/browse/OOZIE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876076#comment-16876076 ]
Hadoop QA commented on OOZIE-3522: ---------------------------------- Testing JIRA OOZIE-3522 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any star imports . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} Javadoc generation succeeded with the patch . {color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [22] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/git]. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:red}-1{color} There are [15] new bugs found below threshold in [tools] that must be fixed, listing only the first [5] ones. . You can find the SpotBugs diff here (look for the red and orange ones): tools/findbugs-new.html . The top [5] most important SpotBugs errors are: . At OozieDBCLI.java:[line 584]: This use of java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL injection . At OozieDBCLI.java:[line 574]: At OozieDBCLI.java:[line 573] . At OozieDBCLI.java:[line 577]: At OozieDBCLI.java:[line 575] . At OozieDBCLI.java:[line 579]: At OozieDBCLI.java:[line 578] . At OozieDBCLI.java:[line 584]: At OozieDBCLI.java:[line 581] . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. . {color:orange}0{color} There are [4] new bugs found in [server] that would be nice to have fixed. . You can find the SpotBugs diff here: server/findbugs-new.html . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:red}-1{color} There are [7] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. . You can find the SpotBugs diff here (look for the red and orange ones): core/findbugs-new.html . The top [5] most important SpotBugs errors are: . At BulkJPAExecutor.java:[line 207]: This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection . At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176] . At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200] . This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207] . At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128] {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} . Tests run : 2967 . Tests failed : 1 . Tests in error : 0 . Tests timed out : 0 {color:red}-1{color} [ERROR] There are [1] test failures in [core]. Listing only the first [5] ones testPurgeableWorkflowPurgeableSubWorkflowPurgeableSubSubWorkflow:org.apache.oozie.command.TestPurgeXCommand Check console output for the full list of errors/failures {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/1158/ > Migrate from Guava's Joiner > --------------------------- > > Key: OOZIE-3522 > URL: https://issues.apache.org/jira/browse/OOZIE-3522 > Project: Oozie > Issue Type: Sub-task > Reporter: Andras Salamon > Assignee: Andras Salamon > Priority: Major > Attachments: OOZIE-3522-01.patch > > > As mentioned in OOZIE-3488 we might use standard JDK classes instead of the > [Joiner|https://guava.dev/releases/11.0.2/api/docs/index.html?com/google/common/base/Joiner.MapJoiner.html] > class of Guava as suggested here: https://stackoverflow.com/a/22577565/21348 -- This message was sent by Atlassian JIRA (v7.6.3#76005)