[ https://issues.apache.org/jira/browse/OOZIE-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899950#comment-16899950 ]
Hadoop QA commented on OOZIE-3468: ---------------------------------- Testing JIRA OOZIE-3468 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any star imports . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} Javadoc generation succeeded with the patch . {color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/git]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} . Tests run: 3175 . {color:orange}Tests failed at first run:{color} TestCoordActionsKillXCommand#testActionKillCommandActionNumbers TestCoordActionsKillXCommand#testActionKillCommandDate . For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/1202/ > Use modernizer plugin > --------------------- > > Key: OOZIE-3468 > URL: https://issues.apache.org/jira/browse/OOZIE-3468 > Project: Oozie > Issue Type: Improvement > Components: build > Affects Versions: trunk > Reporter: Andras Salamon > Assignee: Andras Salamon > Priority: Major > Attachments: OOZIE-3468-01-wip.patch, OOZIE-3468-02-wip.patch, > OOZIE-3468-03-wip.patch, OOZIE-3468-04.patch, OOZIE-3468-06.patch > > > Recently I've opened a few jiras which suggested to use standard java classes > instead of external libraries ( OOZIE-3463, OOZIE-3467). There is a tool > which can find such technical depts: [maven modernizer > plugin|https://github.com/gaul/modernizer-maven-plugin]. > The usage is quite simple: > {noformat} > $ mvn modernizer:modernizer > ... > [ERROR] /src/oozie/core/src/main/java/org/apache/oozie/StringBlob.java:88: > Prefer java.lang.String.<init>(byte[], java.nio.charset.Charset) > > [ERROR] /src/oozie/core/src/main/java/org/apache/oozie/StringBlob.java:122: > Prefer java.nio.charset.StandardCharsets > [ERROR] > /src/oozie/core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java:85: > Prefer java.nio.charset.StandardCharsets > [ERROR] > /src/oozie/core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java:92: > Prefer java.nio.charset.StandardCharsets > [ERROR] > /src/oozie/core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java:188: > Prefer java.util.ArrayList<>() > [ERROR] > /src/oozie/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:91: > Prefer java.lang.StringBuilder > [ERROR] > /src/oozie/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:101: > Prefer java.lang.StringBuilder > [ERROR] > /src/oozie/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:110: > Prefer java.lang.StringBuilder > [ERROR] > /src/oozie/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java:119: > Prefer java.lang.StringBuilder > [ERROR] > /src/oozie/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java:36: > Prefer java.util.Collections.emptyList() > [ERROR] > /src/oozie/core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java:49: > Prefer java.util.Collections.emptyList() > ... > {noformat} > There are several ways to use this plugin: > # Add the plugin to the root pom and let developers manually use this > plugin. It's the simplest solution, but it will be easy to forget it. > # Add this to the precommit script similarly to findbugs and at least avoid > to insert new code which uses old style API. Probably we will have the same > problems like we have with findbugs, we will have lots of false positive > warnings. > # Turn the plugin on by default and fail the compilation if it finds any > problem. I think this is too strict. > If we choose option 2 or 3 we should probably specify an ignore list, I don't > think for instance that we really want to change all the {{new Long(10)}} > code to {{Long.valueOf(10)}}. > By default this plugin checks the target java version (1.8 right now) but > it's possible to specify 1.7 instead if we want to focus on those problems > first. (It was not working for me without specifying the java version.) > -- This message was sent by Atlassian JIRA (v7.6.14#76016)