[ https://issues.apache.org/jira/browse/OOZIE-3540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919807#comment-16919807 ]
Hadoop QA commented on OOZIE-3540: ---------------------------------- Testing JIRA OOZIE-3540 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any star imports . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:green}+1{color} the patch adds/modifies 2 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} Javadoc generation succeeded with the patch . {color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [1] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. . {color:orange}0{color} There are [4] new bugs found in [server] that would be nice to have fixed. . You can find the SpotBugs diff here: server/findbugs-new.html . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/git]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:red}-1{color} There are [1] new bugs found below threshold in [sharelib/oozie] that must be fixed. . You can find the SpotBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html . The most important SpotBugs errors are: . At ShellMain.java:[line 93]: This usage of java/lang/ProcessBuilder.<init>(Ljava/util/List;)V can be vulnerable to Command Injection . At ShellMain.java:[line 91]: At ShellMain.java:[line 90] . At ShellMain.java:[line 92] . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [examples]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} . Tests run: 3175 {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch {color:green}+1 MODERNIZER{color} . {color:green}+1{color} the patch fixes 28 modernizer error(s) ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/1212/ > Use StringBuilder instead of StringBuffer if concurrent access is not required > ------------------------------------------------------------------------------ > > Key: OOZIE-3540 > URL: https://issues.apache.org/jira/browse/OOZIE-3540 > Project: Oozie > Issue Type: Improvement > Components: core > Affects Versions: trunk > Reporter: Zsombor Gegesy > Assignee: Zsombor Gegesy > Priority: Minor > Fix For: 5.2.0 > > Attachments: OOZIE-3540.patch > > > StringBuffer is an old relic from the distant past, Oozie shouldnt' need to > use it, unless concurrent access is expected. -- This message was sent by Atlassian Jira (v8.3.2#803003)