[ 
https://issues.apache.org/jira/browse/OOZIE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926474#comment-16926474
 ] 

Julia Kinga Marton commented on OOZIE-3542:
-------------------------------------------

Thank you [~zsombor] for the fix.

I would have two small comments related this:
 * Please rename the test class to TestECPolicyDisabler.java
 * Please mark somewhere in the name of SystemErasureCodingPolicies that is 
created for tested purposes, so when we are doing class search to know it even 
without opening it. (for example I would rename it to 
SystemErasureCodingPoliciesForTest)

 

> Handle better old Hdfs implementations in ECPolicyDisabler
> ----------------------------------------------------------
>
>                 Key: OOZIE-3542
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3542
>             Project: Oozie
>          Issue Type: Bug
>          Components: tools
>            Reporter: Zsombor Gegesy
>            Assignee: Zsombor Gegesy
>            Priority: Major
>         Attachments: OOZIE-3542-2.patch
>
>
> Currently, ECPolicyDisabler checks if the local hdfs implementation has the 
> necessary methods to get and set erasure coding policy. However, if the 
> namenode implementation is old, it could throw a 
> org.apache.hadoop.ipc.RemoteException with 
> RpcErrorCodeProto.ERROR_NO_SUCH_METHOD value in it.
> In this case, ECPolicyDisabler fails, and prevents the installation to 
> succeed.
> This case should be handled just like, when erasure coding is not supported.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to