[
https://issues.apache.org/jira/browse/OOZIE-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989537#comment-16989537
]
Hadoop QA commented on OOZIE-3566:
----------------------------------
Testing JIRA OOZIE-3566
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any star imports
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} Javadoc generation succeeded with the patch
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 3199
. {color:orange}Tests failed at first run:{color}
TestBlockingInputStream#testLimitedWritingBlockingInputStream
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1262/
> Wrong numbers provided by Oozie monitoring webservices.requests sampler
> -----------------------------------------------------------------------
>
> Key: OOZIE-3566
> URL: https://issues.apache.org/jira/browse/OOZIE-3566
> Project: Oozie
> Issue Type: Bug
> Reporter: Maxim Kolesnikov
> Assignee: Maxim Kolesnikov
> Priority: Major
> Attachments:
> [OOZIE-3566]_Wrong_numbers_provided_by_Oozie_monitoring_webservices_requests_sampler__org_.patch,
> unnamed.png
>
>
> webservices.requests sampler based on
> {code:java}
> org.apache.oozie.servlet.JsonRestServlet#TOTAL_REQUESTS_SAMPLER_COUNTER{code}
> may produce wrong results if
> {code:java}
> org.apache.oozie.servlet.JsonRestServlet#service{code}
> rises an Exception during request URL validation.
>
> TOTAL_REQUESTS_SAMPLER_COUNTER is incremented in try block and decremented in
> finally block right after that. But as validateRestUrl comes before the
> counter is incremented it may lead to situation when counter is decremented
> without being incremented before (in case of validation error).
>
> Attached image is an example graph of webservices.requests being drawn in
> Grafana via Graphite. Pay attention to Y-axis. While most nodes publish
> positive numbers close to 0, some others seems to be shifted off by 1, with
> results close to -1, util two of these nodes jump to numbers close to -2
> around 14:57. At this exact time both servers have URL validation errors in
> their logs, like this:
> {code:java}
> 2019-11-29 14:57:29,394 WARN V2JobServlet:523 - USER[-] GROUP[-] TOKEN[-]
> APP[-] JOB[-] ACTION[-] URL[GET <SANITIZED>] error[E0301], E0301: Invalid
> resource [<SANITIZED>]{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
