[ 
https://issues.apache.org/jira/browse/OOZIE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000849#comment-17000849
 ] 

Andras Salamon commented on OOZIE-3573:
---------------------------------------

Thanks [~arvaiadam] this version is much better. Precommit also likes this. 
Great typo findings.

A few more suggestions:
 * "multiple class" should be "multiple classes" I think.
 * For the "nameNode.whitelist" and "jobTracker.whitelist" we should also add 
the information, that we accept comma separated values. Something like "Comma 
separated list of whitelisted job trackers for Oozie service"
 * I've also realized that the block-copy error is also block-copied to our 
documentation: 
[https://github.com/apache/oozie/blob/master/docs/src/site/markdown/AG_HadoopConfiguration.md]
 Could you please also modify this file.

> Fix oozie-default.xml descriptions
> ----------------------------------
>
>                 Key: OOZIE-3573
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3573
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: trunk
>            Reporter: Andras Salamon
>            Assignee: Adam Arvai
>            Priority: Minor
>         Attachments: OOZIE-3573-001.patch, OOZIE-3573-002.patch
>
>
> The nameNode.whitelist section in 
> [oozie-default.xml|https://github.com/apache/oozie/blob/master/core/src/main/resources/oozie-default.xml]
>  contains the following section:
> {noformat}
> <property>
>         <name>oozie.service.HadoopAccessorService.nameNode.whitelist</name>
>         <value> </value>
>         <description>
>             Whitelisted job tracker for Oozie service.
>         </description>
>     </property>
> {noformat}
> This is clearly a block-copy error, description is copied from the previous 
> {{jobTracker.whitelist}} section.
> We should fix it, maybe it would be useful to check the other description 
> fields in the file as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to