[ 
https://issues.apache.org/jira/browse/OOZIE-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002140#comment-17002140
 ] 

Andras Salamon commented on OOZIE-3574:
---------------------------------------

Thanks for the patch [~zuston]. The modification looks good to me. Could you 
please also add a unit test to 
[TestJavaActionExecutorLibAddition.java|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutorLibAddition.java].
 A test which fails with the original code but passes with your fix could be 
really useful here.

> JavaAction create incorrect fileSystem instance in addActionLibs method
> -----------------------------------------------------------------------
>
>                 Key: OOZIE-3574
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3574
>             Project: Oozie
>          Issue Type: Sub-task
>            Reporter: Junfan Zhang
>            Assignee: Junfan Zhang
>            Priority: Major
>         Attachments: OOZIE-3574-v1.patch
>
>
> Code is 
> [here|https://github.com/apache/oozie/blob/9c288fe5cea6f2fbbae76f720b9e215acdd07709/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L734].
> If actionlibPath scheme is different from appPath (like actionLibPath's 
> scheme is s3a, but the appPath is hdfs), this will fail to execute 
> {{fs.exist(actionLibsPath)}}. So i think Oozie should create fileSystem by 
> actionLibsPath.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to