[ 
https://issues.apache.org/jira/browse/OOZIE-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010494#comment-17010494
 ] 

Andras Salamon commented on OOZIE-3066:
---------------------------------------

Thanks for the quick patch [~qsbao] I like the approach, I only have a few 
suggestions:
 * It's a very good idea to check the default and the max and return max if 
default>max. I think we should also print out a warning message in this case.
 * The default 0 is hardwired twice in the code. Once in {{oozie-default.xml}} 
and once in the {{ConfigurationService.getInt(CONF_USER_RETRY_DEFAULT, 0);}} 
line. I think we only need to hardwire it only into the xml. Please check 
OOZIE-1890 and OOZIE-3462 for the reasons.
 * Can you please add some meaninful assert messages to your unit test asserts. 

> Possibility to set retry-max globally
> -------------------------------------
>
>                 Key: OOZIE-3066
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3066
>             Project: Oozie
>          Issue Type: New Feature
>    Affects Versions: trunk
>            Reporter: Gézapeti
>            Assignee: Qs Bao
>            Priority: Major
>         Attachments: OOZIE-3066-001.patch
>
>
> Currently there is no way to set the equivalent of {{retry-max}} globally to 
> apply to every action.
> It should be possible to set a default value to that to make workflow 
> execution more reliable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to