[ https://issues.apache.org/jira/browse/OOZIE-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019339#comment-17019339 ]
Andras Salamon commented on OOZIE-3569: --------------------------------------- Thanks [~zuston] for the new patch, I like the change. The harmfulness of this patch makes me wonder. [~gezapeti] Do we have some best practices for these kind of patches? > SSH Action should add checking success file > ------------------------------------------- > > Key: OOZIE-3569 > URL: https://issues.apache.org/jira/browse/OOZIE-3569 > Project: Oozie > Issue Type: Bug > Reporter: Junfan Zhang > Assignee: Junfan Zhang > Priority: Major > Attachments: OOZIE-3569-v1.patch, OOZIE-3569-v2.patch > > > *Phenomenon* > Currently, {{SSH Action}} checking operation are as following: > Firstly, check operation is to check {{Oozie}} ppid. When pgid does not > exist, check whether there is an error file. If the error file does not > exist, {{Oozie}} will set action status {{OK}} > However, when {{Oozie}} pgid is killed externally, this action will be > incorrectly determined to be successful. > *Solution* > In ssh-wrapper.sh, when command execution is OK, {{Oozie}} should touch a > success empty file like touching error file. > In {{SshActionExecutor}} check method, Oozie should add checking the success > file existence. -- This message was sent by Atlassian Jira (v8.3.4#803005)