[
https://issues.apache.org/jira/browse/OOZIE-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342648#comment-17342648
]
Hadoop QA commented on OOZIE-3621:
----------------------------------
Testing JIRA OOZIE-3621
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any star imports
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} Javadoc generation succeeded with the patch
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [15] new bugs found below threshold in total
that must be fixed.
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:red}-1{color} There are [15] new bugs found below threshold in
[tools] that must be fixed, listing only the first [5] ones.
. You can find the SpotBugs diff here (look for the red and orange ones):
tools/findbugs-new.html
. The top [5] most important SpotBugs errors are:
. At OozieDBCLI.java:[line 584]: This use of
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL
injection
. At OozieDBCLI.java:[line 574]: At OozieDBCLI.java:[line 573]
. At OozieDBCLI.java:[line 577]: At OozieDBCLI.java:[line 575]
. At OozieDBCLI.java:[line 579]: At OozieDBCLI.java:[line 578]
. At OozieDBCLI.java:[line 584]: At OozieDBCLI.java:[line 581]
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 3215
. {color:orange}Tests failed at first run:{color}
TestBulkMonitorWebServiceAPI#testBundleId
TestBlockingInputStream#testLimitedWritingBlockingInputStream
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/15/
> Make TestECPolicyDisabler work with Hadoop 3
> --------------------------------------------
>
> Key: OOZIE-3621
> URL: https://issues.apache.org/jira/browse/OOZIE-3621
> Project: Oozie
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Priority: Major
> Attachments: OOZIE-3621.v0.patch
>
>
> TestECPolicyDisabler is not compatible with hadoop 3. The following error
> messages are produced by command `mvn clean install -DskipTests
> -Dhadoop.version=3.1.0 -Dhadoop.majorversion=3 -Phadoop-3`
> {quote}
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR]
> /home/chia7712/oozie/tools/src/test/java/org/apache/oozie/tools/TestECPolicyDisabler.java:[50,71]
> getErasureCodingPolicy(org.apache.hadoop.fs.Path) in
> org.apache.oozie.tools.TestECPolicyDisabler.MockDistributedFileSystem cannot
> override getErasureCodingPolicy(org.apache.hadoop.fs.Path) in
> org.apache.hadoop.hdfs.DistributedFileSystem
> return type
> org.apache.hadoop.hdfs.protocol.SystemErasureCodingPolicies.ReplicationPolicy
> is not compatible with org.apache.hadoop.hdfs.protocol.ErasureCodingPolicy
> {quote}
> The root cause is the method `getErasureCodingPolicy` was introduced in
> hadoop 3 and the method signature is different to mock fs of
> TestECPolicyDisabler. Fortunately, all we want to test is the static method
> 'ECPolicyDisabler#check' so we can add a new argument to make it be able to
> check another method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
