[
https://issues.apache.org/jira/browse/OOZIE-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579683#comment-17579683
]
Hadoop QA commented on OOZIE-3666:
----------------------------------
Testing JIRA OOZIE-3666
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any star imports
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} Javadoc generation succeeded with the patch
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [2] new bugs found below threshold in total that
must be fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [2] new bugs found below threshold in
[core] that must be fixed.
. You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important SpotBugs errors are:
. At ShareLibService.java:[line 695]: Unsafe comparison of hash that are
susceptible to timing attack
. At ShareLibService.java:[line 691]: At ShareLibService.java:[line 689]
. Possible injection that can lead to Source spoofing, header override and
email body injection.: At ShareLibService.java:[line 693]
. At SLAEmailEventListener.java:[line 286]: At
SLAEmailEventListener.java:[line 294]
. At SLAEmailEventListener.java:[line 288]: At
SLAEmailEventListener.java:[line 287]
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 3218
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/91/
> Oozie log streaming bug when log timestamps are the same on multiple Oozie
> servers
> ----------------------------------------------------------------------------------
>
> Key: OOZIE-3666
> URL: https://issues.apache.org/jira/browse/OOZIE-3666
> Project: Oozie
> Issue Type: Bug
> Components: core
> Reporter: Janos Makai
> Assignee: Janos Makai
> Priority: Major
> Labels: usability
> Attachments: OOZIE-3666-001.patch, OOZIE-3666-002.patch
>
>
> We have found a bug in the mechanism of the Oozie log streaming.
> Affected code lines:
> [https://github.com/apache/oozie/blob/release-5.2.1/core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java#L221L250]
> This code is responsible for collating all of the logs from the available
> Oozie servers.However, in case there is a log message in server "A" with the
> same timestamp as an other log message in server "B", then according to the
> current implementation, the logs acquired by using `TimestampedMessageParser`
> corresponding to server "B" will be overwritten by server "A" 's parser (due
> to the operation ofÂ
> {*}{color:#0747a6}timestampMap.put(earliestParser.getLastTimestamp(),
> earliestParser){color}{*}), therefore causing the log messages from server
> "B" to be ignored from that point.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
