[ 
https://issues.apache.org/jira/browse/OOZIE-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643459#comment-17643459
 ] 

Hadoop QA commented on OOZIE-3679:
----------------------------------


Testing JIRA OOZIE-3679

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any star imports
.    {color:green}+1{color} the patch does not introduce any line longer than 
132
.    {color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} Javadoc generation succeeded with the patch
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [22] new bugs found below threshold in total 
that must be fixed.
.    {color:green}+1{color} There are no new bugs found in [webapp].
.    {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
.    {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.    {color:green}+1{color} There are no new bugs found in [sharelib/spark].
.    {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.    {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.    {color:green}+1{color} There are no new bugs found in [sharelib/git].
.    {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.    {color:green}+1{color} There are no new bugs found in [sharelib/hive].
.    {color:green}+1{color} There are no new bugs found in [sharelib/pig].
.    {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.    {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.    {color:red}-1{color} There are [15] new bugs found below threshold in 
[tools] that must be fixed, listing only the first [5] ones.
.    You can find the SpotBugs diff here (look for the red and orange ones): 
tools/findbugs-new.html
.    The top [5] most important SpotBugs errors are:
.    At OozieDBCLI.java:[line 584]: This use of 
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL 
injection
.    At OozieDBCLI.java:[line 574]: At OozieDBCLI.java:[line 573]
.    At OozieDBCLI.java:[line 577]: At OozieDBCLI.java:[line 575]
.    At OozieDBCLI.java:[line 579]: At OozieDBCLI.java:[line 578]
.    At OozieDBCLI.java:[line 584]: At OozieDBCLI.java:[line 581]
.    {color:green}+1{color} There are no new bugs found in [server].
.    {color:green}+1{color} There are no new bugs found in [examples].
.    {color:green}+1{color} There are no new bugs found in [docs].
.    {color:green}+1{color} There are no new bugs found in [client].
.    {color:red}-1{color} There are [7] new bugs found below threshold in 
[core] that must be fixed, listing only the first [5] ones.
.    You can find the SpotBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
.    The top [5] most important SpotBugs errors are:
.    At BulkJPAExecutor.java:[line 206]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
.    At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.    At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.    This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206]
.    At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run        : 3259
.    Tests failed     : 1
.    Tests in error   : 0
.    Tests timed out  : 0

{color:red}-1{color} [ERROR] There are [1] test failures in [core]. Listing 
only the first [5] ones
testIfNoCustomFsConfigProvidedBaseConfigRemainsTheSame:org.apache.oozie.service.TestHadoopAccessorService

Check console output for the full list of errors/failures
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 
{color:green}+1 MODERNIZER{color}

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/159/



> Correct maximum wait time between database retry attempts property
> ------------------------------------------------------------------
>
>                 Key: OOZIE-3679
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3679
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Janos Makai
>            Assignee: Janos Makai
>            Priority: Major
>         Attachments: OOZIE-3679-001.patch, OOZIE-3679-002.patch, 
> OOZIE-3679-003.patch
>
>
> Based on the oozie-default.xml:
> {code:xml}
> <property>
>     <name>oozie.service.JPAService.retry.maximum-wait-time.ms</name>
>     <value>30000</value>
>     <description>
>           Maximum wait time between database retry attempts.
>     </description>
> </property>
> {code}
> it looks like we are missing a "{_}retry{_}" string before the maximum wait 
> time between database retry attempts static string in Oozie's JPAService:
> {code:java}
> public static final String MAX_WAIT_TIME = CONF_PREFIX + 
> "maximum-wait-time.ms";
> {code}
> {color:#172b4d}The goal of this change is to sync the config names between 
> oozie-default.xml and Oozie but we should also support the old, invalid 
> config name.{color}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to