hadonchen opened a new pull request, #87:
URL: https://github.com/apache/oozie/pull/87
When I fork 2 transitions( A and B) to submit , when A fail , B still
Running , because can't execute KillXCommand.
ActionXCommand execute failJob and add KillXCommand to commandQueue ,
but the commandQueue is the new Bean ActionXCommand not the SignalXCommand , so
can't execute KillXCommand. The code is as follows
`
new ActionStartXCommand(context.getAction().getId(), null).failJob(context)
public void failJob(ActionExecutor.Context context, WorkflowActionBean
action) throws CommandException {
WorkflowJobBean workflow = (WorkflowJobBean) context.getWorkflow();
if (!handleUserRetry(context, action)) {
incrActionErrorCounter(action.getType(), "failed", 1);
LOG.warn("Failing Job due to failed action [{0}]",
action.getName());
try {
workflow.getWorkflowInstance().fail(action.getName());
WorkflowInstance wfInstance = workflow.getWorkflowInstance();
((LiteWorkflowInstance)
wfInstance).setStatus(WorkflowInstance.Status.FAILED);
workflow.setWorkflowInstance(wfInstance);
workflow.setStatus(WorkflowJob.Status.FAILED);
action.setStatus(WorkflowAction.Status.FAILED);
action.resetPending();
**queue(new WorkflowNotificationXCommand(workflow, action));
queue(new KillXCommand(workflow.getId()));**
InstrumentUtils.incrJobCounter(INSTR_FAILED_JOBS_COUNTER_NAME, 1,
getInstrumentation());
}
catch (WorkflowException ex) {
throw new CommandException(ex);
}
}
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@oozie.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
