[
https://issues.apache.org/jira/browse/OOZIE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713860#comment-17713860
]
Hadoop QA commented on OOZIE-3716:
----------------------------------
Testing JIRA OOZIE-3716
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any star imports
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} Javadoc generation succeeded with the patch
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [5] new bugs found below threshold in total that
must be fixed.
. {color:red}-1{color} There are [5] new bugs found below threshold in
[core] that must be fixed.
. You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important SpotBugs errors are:
. At BulkJPAExecutor.java:[line 206]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
. At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
. At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
. This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206]
. At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127]
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 3259
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/208/
> Invocation of Main class completed Message is skipped when
> LauncherSecurityManager calls system exit
> ----------------------------------------------------------------------------------------------------
>
> Key: OOZIE-3716
> URL: https://issues.apache.org/jira/browse/OOZIE-3716
> Project: Oozie
> Issue Type: Wish
> Components: action
> Affects Versions: 5.0.0, 5.1.0, 5.2.0, 5.3.0, 5.2.1
> Reporter: halim kim
> Assignee: halim kim
> Priority: Minor
> Fix For: 5.3.0
>
> Attachments: OOZIE-3716.patch
>
>
> When you execute oozie java action, there is no message like below if
> LauncherSecurityManager throws an exceptions.
> {code:java}
> <<< Invocation of Main class completed <<<
> {code}
> However, if system exit code from LauncherSecurityManager is zero, it is
> possible to consider main() method finished successfully.
> Therefore, there is no problem with printing "*<<< Invocation of Main class
> completed <<<*" message in such cases.
> Oozie 4.x version prints the message in finally block but Oozie 5.x version
> does not(There is Transition from LauncherMapper to LauncherAM class in oozie
> 5.x version.)
> https://github.com/apache/oozie/blob/3d0843260199799be634dc330d98f1362536fcd5/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java#L232-L272
> This issue feels trivial but can cause a problem in hue editor.
> hue uses regular expression to distinguish whether oozie java action is
> successfull or not.
> https://github.com/cloudera/hue/blob/c0443438e9a29b9fbf22566022aeef27fc4c606b/desktop/libs/notebook/src/notebook/connectors/oozie_batch.py#L54
> The regular expression does not match if there is no "<<< Invocation of Main
> class completed <<<" message so that hue considers oozie java action is not
> completed even though main method of oozie java action is successful.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
