Hi Several things need to understand before voting.
1. I remember I was asked about OpenDAL copying some source codes to increase maintenance. Did that copy happen? If so, the LICENSE file should be updated. 2. I can see `DISCLAIMER` in the folder, so, is the OpenDAL going to skip the check for licenses of dependencies this time? 3. I can see the `binding` folder includes other languages. Is the compiling apply to all languages? 4. Compiling fails by using `cargo build --workspace --all-targets`. Maybe you need a better compiling guide. One line command is not not going to work for everyone and every platform. > M1 Max MacOS 13.2.1 > rustc 1.65.0 (897e37553 2022-11-02) > cargo 1.65.0 (4bc8f24d3 2022-10-20) Sheng Wu 吴晟 Twitter, wusheng1108 Xuanwo <[email protected]> 于2023年3月16日周四 20:40写道： > > Hi, @sundyli > > Please download, verify, and test our release as required. > Instead of a simple +1 or approval, kindly fill out the forms provided below. > > On Thu, Mar 16, 2023, at 20:33, sundyli wrote: > > +1 approve > > > > Xuanwo <[email protected]> 于2023年3月16日周四 15:52写道： > > > >> Hello, Apache OpenDAL(incubating) PMC and Community, > >> > >> This is a call for a vote to release Apache OpenDAL(incubating) version > >> 0.30.3. > >> > >> The tag to be voted on is 0.30.3. > >> > >> The release candidate: > >> > >> https://dist.apache.org/repos/dist/dev/incubator/opendal/0.30.3-rc1/ > >> > >> Keys to verify the release candidate: > >> > >> https://downloads.apache.org/incubator/opendal/KEYS > >> > >> Git branch for the release: > >> > >> https://github.com/apache/incubator-opendal/tree/release-0.30.3-rc1 > >> > >> Please download, verify, and test. > >> > >> The VOTE will remain open for at least 72 hours. > >> > >> [ ] +1 approve > >> [ ] +0 no opinion > >> [ ] -1 disapprove with the reason > >> > >> To learn more about apache opendal, please see https://opendal.apache.org/ > >> > >> Checklist for reference: > >> > >> [ ] Download links are valid. > >> [ ] Checksums and signatures. > >> [ ] LICENSE/NOTICE files exist > >> [ ] No unexpected binary files > >> [ ] All source files have ASF headers > >> [ ] Can compile from source > >> [ ] All Tests Passed > >> > >> More detailed checklist please refer to: > >> https://github.com/apache/incubator-opendal/tree/main/scripts > >> > >> To compile from source, please setup https://rustup.rs/ and running: > >> > >> cargo build --workspace --all-targets > >> > >> To running tests, please running: > >> > >> cargo test --workspace --all-targets > >> > >> Thanks > >> > >> Xuanwo > >> > > -- > Xuanwo
