We usually exclude the .idea files, as it may introduce some personal configurations to the project. I'm OK with adding the IDE project setting file to the repo if it is a common setting, otherwise it will cause some trouble for the developer who has to change them to meet their personal needs.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Mar 12, 2024 at 7:06 PM Manjusaka <[email protected]> wrote: > > On 2024/3/12 19:00, tison wrote: > > This folder may help - > > https://github.com/apache/incubator-streampark/tree/dev/.idea > > > > Best, > > tison. > > > > > > tison <[email protected]> 于2024年3月12日周二 18:59写道： > > > >> *.iml varies from personal setup. But vcs.xml would be the some. So does > >> some common .vscode/settings.json > >> > >> I'm +1 on checking in these files, but with caution that it's really > >> sharing common practice. > >> > >> Best, > >> tison. > >> > >> > >> Xuanwo <[email protected]> 于2024年3月12日周二 18:55写道： > >> > >>> Hello, community > >>> > >>> OpenDAL has become a complex project, requiring users to perform several > >>> IDE-related setups for full functionality. For instance, it's necessary to > >>> configure the `Content Root` in IDEA so that it can recognize different > >>> crates rather than just reading from the root directory. > >>> > >>> So do you think it's a good idea to commit part of .idea and .vscode to > >>> project? We can bring some useful things like "opendal.iml" and > >>> "modules.xml" into the repo. > >>> > >>> Xuanwo > >>> > >> > > > > > +1 strongly for .vscode, I think all of the developer in the OpenDAL > community who is using the vscode have a lot same config like > > ```json > { > "rust-analyzer.cargo.features": "all", > "rust-analyzer.linkedProjects":[ > "${workspaceFolder}/core/Cargo.toml", > "${workspaceFolder}/bindings/java/Cargo.toml" > ] > } > ``` > > But I'm not sure for the .idea. In my experience, there are three options for > the developer,the IDEA for Java, Rustover for Rust, old style Clion for Rust. > Each of the option may generate conflict config for other option. > > But anyway, .vscode is necessary!
