On Jun 9, 2010, at 7:43 PM, Ivan wrote:
> Hi, David :
> Seems that we could do the samething for AroundTimeout, if no one has
> begun the work, could you assign the JIRA OpenEJB-1172 to me ? I could like
> to work on it.
Excellent, will assign that one to you!
Thanks for the validation patch! We probably still want to expand the test a
little more to cover the other checks and messages keys we added. More or less
just prune out the unused message keys and write tests to cover the keys that
are used.
There are more message keys than checks obviously, but I figured it would be
good to commit them to svn anyway so at least they were some place safe if we
wanted to add checks for them later. I mean, you took the time to write them
already, why not at least get them checked in :)
[added checks]
Modified:
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java
+ fail(bean, "callback.badModifier", type,
callback.getMethodName(), callback.getClassName());
+ fail(bean, "calllback.invalidSessionSynchronizationUse",
ejbClass.getName());
+ fail(bean, "callback.sessionSynchronization.invalidUse",
ejbClass.getName());
[added keys]
Modified:
openejb/trunk/openejb3/container/openejb-core/src/main/resources/org/apache/openejb/config/rules/Messages.properties
+1.callback.badModifier = {0} method must not be final and static
+1.callback.sessionSynchronization.invalidUse = Session synchronizatio...
+1.ann.sessionsynchronization.invalidModifier = @AfterBegin, @BeforeCo...
+1.ann.sessionsynchronization.invalidReturnValue = The return type of ...
+1.ann.sessionsynchronization.noBooleanParameter = The method annotate...
+1.ann.sessionsynchronization.noEmptyParameter = The method annotated ...
+1.ann.sessionSynchronization.invalidUse = Session synchronization ann...
+1.ann.sessionSynchronization.methodNotFound = The session synchroniza...
+1.ann.sessionsynchronization.duplicatedAnnotatedMethod = Each statefu...
No rush on this. Feel free to do it whenever is convenient.
-David
