On Jun 24, 2010, at 12:48 PM, Thiago Veronezi wrote: > Hi, devs! > Im still alive... Im just having a good rush at work these days. Anyways, I > just found an opportunity to contribute for both projects. :O)
:) > I've opened and fixed the following issue: > https://issues.apache.org/jira/browse/OPENEJB-1304 > When you have time, please review this guy for me. Looks like there may be a startup ordering issue related to this added feature: https://issues.apache.org/jira/browse/OPENEJB-1296 I committed the part of the patch that deals with avoiding calling PreDestroy on instances that where never created -- good catch! The assembler fix that changes the sort order isn't quite right as it is essentially what we had before OPENEJB-1296, but clearly something along that lines will be needed. I'm not sure if this will work, but I tried adding back in the "sort singletons to the back" sort but this time before the @DependsOn sort so the @DependsOn will still take precedence. That's the theory anyway, not sure if the @DependsOn is a stable sort -- seem to recall it was slightly unstable -- and it may not do the trick. Any chance you can give it a whirl and let us know if it does the trick? Thanks for reporting this, Thiago! -David
